Fix env vars2 (#538)

* fix envVar option

* fix env vars

Author: oren-codefresh

lib/interface/cli/commands/hybrid/helper.js

@@ -488,7 +488,9 @@ async function installAgent({
         cmd.push('--verbose');
     }
     if (envVars) {
-        cmd.push(`--envVars=${envVars}`);
+        envVars.forEach((element) => {
+            cmd.push(`--envVars=${element}`);
+        });
     }
 
     await componentRunner.run(components.venona, cmd);
@@ -673,22 +675,6 @@ async function newAgentName(kubeContextName, kubeNamespace, agents) {
 
     return name;
 }
-// eslint-disable-next-line consistent-return
-function keyValueAsArrayToObject(array) {
-    if (array) {
-        const obj = {};
-        for (let index = 0; index < array.length; index++) {
-            const element = array[index];
-            const envVar = element.split('=');
-            if (envVar.length !== 2) {
-                throw new Error(`invalid env-var parameter ${envVar}`);
-            }
-            // eslint-disable-next-line prefer-destructuring
-            obj[envVar[0]] = envVar[1];
-        }
-        return obj;
-    }
-}
 function keyValueAsStringToObject(nodeSelectorStr) {
     if (nodeSelectorStr) {
         const kubeNodeSelectorObj = {};

lib/interface/cli/commands/hybrid/init.cmd.js

@@ -30,7 +30,6 @@ const {
     newAgentName,
     detectProxy,
     keyValueAsStringToObject,
-    serealizeToKeyValuePairs,
     getRuntimeImagesWithRegistryUrl,
     keyValueAsArrayToObject,
     INSTALLATION_DEFAULTS,
@@ -205,10 +204,6 @@ const initCmd = new Command({
             'https-proxy': httpsProxy,
         } = _argv;
 
-        if (envVars) {
-            envVars = keyValueAsArrayToObject(Array.isArray(envVars) ? envVars.join(',') : [envVars]);
-        }
-
         if (_.get(sdk, 'config.context.isNoAuth') && !token) {
             console.log('Not authenticated as a Codefresh account: ');
             console.log('In order to install a Codefresh Runner you need to provide ' +
@@ -413,7 +408,7 @@ const initCmd = new Command({
                     dockerRegistry,
                     verbose,
                     agentId: installationPlan.getContext('agentName'),
-                    envVars: serealizeToKeyValuePairs(envVars),
+                    envVars,
                 });
             },
             installationEvent: installationProgress.events.AGENT_INSTALLED,

package.json

@@ -1,6 +1,6 @@
 {
   "name": "codefresh",
-  "version": "0.71.0",
+  "version": "0.71.1",
   "description": "Codefresh command line utility",
   "main": "index.js",
   "preferGlobal": true,