SAAS-4818 #time 0h 50m refatoring of cmd command (#381)

* SAAS-4818 #time 0h 50m refatoring of cmd command

* SAAS-4818 #time 0h 1m игьз

* SAAS-4818 #time 0h 20m Made some properties as static

* rebuild

Co-authored-by: olegz-codefresh <[email protected]>
Co-authored-by: Denis Melnik <[email protected]>

Author: 3 people

lib/interface/cli/commands/root/create.cmd.js

@@ -2,14 +2,19 @@ const _ = require('lodash');
 const CFError = require('cf-errors');
 const Command = require('../../Command');
 const { crudFilenameOption } = require('../../helpers/general');
-const creatingEntities = require('../../helpers/creatingEntities');
+const EntitiesManifests = require('../../helpers/entitiesManifests');
 const yargs = require('yargs');
 
+function _getSupportedResourcesStr() {
+    return EntitiesManifests.list
+        .map(entity => `\n\t'${entity}'`)
+        .join('');
+}
 const get = new Command({
     root: true,
     command: 'create',
     description: 'Create a resource from a file or stdin',
-    usage: 'Supported resources: \n\t\'context\'\n\t\'pipeline\'\'\n\t\'step-type\'',
+    usage: `Supported resources: ${_getSupportedResourcesStr()}`,
     webDocs: {
         description: 'Create a resource from a file, directory or url',
         category: 'Operate On Resources',
@@ -34,13 +39,8 @@ const get = new Command({
             throw new CFError('Name is missing');
         }
 
-        const entities = creatingEntities({ name, data });
-
-        if (!entities[entity]) {
-            throw new CFError(`Entity: ${entity} not supported`);
-        }
-
-        await entities[entity]();
+        const manifests = new EntitiesManifests({ name, data });
+        await manifests.createEntity(entity);
         console.log(`${_.capitalize(entity)}: ${name} created`);
     },
 });

lib/interface/cli/helpers/creatingEntities.js

@@ -0,0 +1,34 @@
+const _ = require('lodash');
+const CFError = require('cf-errors');
+const { validatePipelineSpec, checkOrProjectExists } = require('./validation');
+const { sdk } = require('../../../logic');
+
+class EntitiesManifests {
+    constructor({ name, data } = {}) {
+        this.name = name;
+        this.data = data;
+    }
+
+    createEntity(entity) {
+        if (!EntitiesManifests._entities[entity]) {
+            throw new CFError(`Entity: ${entity} not supported`);
+        }
+        return EntitiesManifests._entities[entity]({
+            name: this.name,
+            data: this.data,
+        });
+    }
+}
+
+EntitiesManifests._entities = {
+    context: ({ data }) => sdk.contexts.create(data),
+    'step-type': ({ data }) => sdk.steps.create(data),
+    project: ({ name, data }) => checkOrProjectExists(name)
+        .then(() => sdk.projects.create({ projectName: name, ..._.pick(data.metadata, ['tags', 'variables']) })),
+    pipeline: ({ data }) => validatePipelineSpec(data)
+        .then((result = {}) => (result.valid ? sdk.pipelines.create(data) : console.warn(result.message))),
+};
+
+EntitiesManifests.list = Object.keys(EntitiesManifests._entities);
+
+module.exports = EntitiesManifests;

lib/interface/cli/helpers/entitiesManifests.js

@@ -1,7 +1,6 @@
 const _ = require('lodash');
 const helper = require('./image');
-const moment = require('moment');
-const creatingEntities = require('./creatingEntities');
+const EntitiesManifests = require('./entitiesManifests');
 
 const { extractImages } = helper;
 
@@ -19,12 +18,11 @@ describe('helpers unit tests', () => {
             request.mockClear();
             await configureSdk(); // eslint-disable-line
         });
-        const entities = creatingEntities({});
-        it('should be an Object', () => expect(entities instanceof Object).toBe(true));
-        it('should have some size', () => expect(_.size(entities)).not.toBe(0));
-        for (const entity in entities) {
-            it(`${entity} should be a function`, () => expect(entities[entity] instanceof Function).toBe(true));
-            it(`${entity} should be promise`, () => expect(entities[entity]().catch(() => null) instanceof Promise).toBe(true));
+        const manifests = new EntitiesManifests({});
+
+        it('should have some length', () => expect(EntitiesManifests.list.length).not.toBe(0));
+        for (const entity of EntitiesManifests.list) {
+            it(`${entity} should be promise`, () => expect(manifests.createEntity(entity).catch(() => null) instanceof Promise).toBe(true));
         }
     });
 

lib/interface/cli/helpers/helpers.unit.spec.js

@@ -3,4 +3,3 @@ const sdk = require('./sdk');
 module.exports = {
     sdk,
 };
-

lib/logic/index.js

@@ -1,6 +1,6 @@
 {
   "name": "codefresh",
-  "version": "0.39.3",
+  "version": "0.39.4",
   "description": "Codefresh command line utility",
   "main": "index.js",
   "preferGlobal": true,