Security patches (#371)

* security patch: update cf-errors

* security patches, Dockerfile:
change the node base image
change the way jq and yq are installed
clean yarn cache
remove yarn from the prod image

* Update codefresh.yml

* Update package version

Author: alex-codefresh

Dockerfile

@@ -1,22 +1,34 @@
 FROM golang:alpine as go
 
-RUN apk add --update ca-certificates git
+RUN apk --update add ca-certificates git
+
 RUN go get github.com/github/hub
 
-FROM node:10.15.3-alpine
+FROM codefresh/node:10.15.3-alpine3.11
+
+RUN apk --update add --no-cache ca-certificates git curl bash yarn
 
-RUN apk add --update ca-certificates git curl jq py-pip bash && pip install yq
 COPY --from=go /go/bin/hub /usr/local/bin/hub
+
+ARG JQ_VERSION=1.6
+ARG YQ_VERSION=2.4.1
+
+RUN wget -O /usr/local/bin/jq https://github.com/stedolan/jq/releases/download/jq-${JQ_VERSION}/jq-linux64 && \
+    wget -O /usr/local/bin/yq https://github.com/mikefarah/yq/releases/download/${YQ_VERSION}/yq_linux_amd64 && \
+    chmod +x /usr/local/bin/*
+
 WORKDIR /cf-cli
 
 COPY package.json /cf-cli
 COPY check-version.js /cf-cli
 
-RUN yarn --prod install
+RUN yarn install --prod --frozen-lockfile && \
+    yarn cache clean
 
 COPY . /cf-cli
 
 RUN yarn generate-completion
+RUN apk del yarn
 
 RUN ln -s $(pwd)/lib/interface/cli/codefresh /usr/local/bin/codefresh
 

codefresh.yml

@@ -12,19 +12,19 @@ steps:
 
   install_dependencies:
     title: 'Installing testing dependencies'
-    image: codefresh/node-tester-image:8.8.0
+    image: codefresh/node-tester-image:10.15.3
     commands:
         - yarn install --frozen-lockfile
 
   eslint:
     title: 'Running linting logic'
-    image: codefresh/node-tester-image:8.8.0
+    image: codefresh/node-tester-image:10.15.3
     commands:
         - yarn eslint
 
   unit-tests:
     title: 'Running unit tests'
-    image: codefresh/node-tester-image:8.8.0
+    image: codefresh/node-tester-image:10.15.3
     commands:
         - yarn test
 

package.json

@@ -34,7 +34,7 @@
     "@codefresh-io/docker-reference": "^0.0.5",
     "ajv": "^6.6.1",
     "bluebird": "^3.5.1",
-    "cf-errors": "^0.1.11",
+    "cf-errors": "^0.1.12",
     "chalk": "^1.1.3",
     "cli-progress": "^1.6.1",
     "codefresh-sdk": "1.4.0",