Fix wrong parameter passing to logic of images. Refactor tag names to be a positional (#88)

Author: itai-codefresh

lib/interface/cli/commands/image/tag.cmd.js

@@ -7,28 +7,29 @@ const { image } = require('../../../../logic').api;
 
 const tag = new Command({
     root: true,
-    command: 'tag <id>',
+    command: 'tag <id> [tags..]',
     description: 'Add an image tag',
     builder: (yargs) => {
         yargs
-            .option('tag', {
-                describe: 'image tags',
-                type: 'array',
-                require: true,
+            .positional('id', {
+                description: 'Docker image id',
+            })
+            .positional('names', {
+                description: 'Tag names',
             });
 
         return yargs;
     },
     handler: async (argv) => {
         const imageId = argv.id;
-        const tags = _.isArray(argv.tag) ? argv.tag : [argv.tag];
+        const tags = argv.tags;
         for (let i = 0; i < tags.length; i += 1) {
             const tag = tags[i];
             await image.addImageTag({
                 imageId,
                 tag,
             });
-            console.log(`tag: ${tag} successfully added to image ${imageId}`);
+            console.log(`Tag: ${tag} was added successfully to image: ${imageId}`);
         }
     },
 });

lib/logic/api/image.js

@@ -136,7 +136,7 @@ const annotateImage = async (dockerImageId, annotations) => {
 };
 
 const addImageTag = async (options) => {
-    const image = await getImageById(options.imageId);
+    const image = await getImageById({ imageId: options.imageId });
     const imageId = image[0].info._id;
     const RequestOptions = {
         url: `/api/images/${encodeURIComponent(imageId)}/tag/${options.tag}`,