Saas 1465 (#335)

* added approve build

* approve & deny

* fixed some lint errors

* moved files from ROOT to WORKFLOW

* changed workflow to workflows

* updated version

Author: ilan-codefresh

lib/interface/cli/codefresh

@@ -22,4 +22,3 @@ if (process.argv.includes('--get-yargs-completions')) {
         process.exit(1);
     });
 }
-

lib/interface/cli/commands/root/root.sdk.spec.js

@@ -2,16 +2,22 @@ let createCmd = require('./create.cmd');
 let replaceCmd = require('./replace.cmd');
 let deleteCmd = require('./delete.cmd');
 let versionCmd = require('./version.cmd');
+let approveCmd = require('../workflow/approve.cmd');
+let denyCmd = require('../workflow/approve.cmd');
 
 createCmd.requiresAuthentication = false;
 replaceCmd.requiresAuthentication = false;
 deleteCmd.requiresAuthentication = false;
 versionCmd.requiresAuthentication = false;
+approveCmd.requiresAuthentication = false;
+denyCmd.requiresAuthentication = false;
 
 createCmd = createCmd.toCommand();
 replaceCmd = replaceCmd.toCommand();
 deleteCmd = deleteCmd.toCommand();
 versionCmd = versionCmd.toCommand();
+approveCmd = approveCmd.toCommand();
+denyCmd = denyCmd.toCommand();
 
 
 jest.mock('../../helpers/validation', () => { // eslint-disable-line
@@ -152,4 +158,24 @@ describe('root commands', () => {
             });
         });
     });
+
+    describe('Approve pending-approval workflow', () => {
+        it('should handle approve from spec', async () => {
+            const argv = {
+                buildId: 'buildId'
+            };
+            await approveCmd.handler(argv);
+            await verifyResponsesReturned([DEFAULT_RESPONSE, DEFAULT_RESPONSE]); // eslint-disable-line
+        });
+    });
+
+    describe('Deny pending-approval workflow', () => {
+        it('should handle deny from spec', async () => {
+            const argv = {
+                buildId: 'buildId'
+            };
+            await denyCmd.handler(argv);
+            await verifyResponsesReturned([DEFAULT_RESPONSE, DEFAULT_RESPONSE]); // eslint-disable-line
+        });
+    });
 });

lib/interface/cli/commands/workflow/approve.cmd.js

@@ -0,0 +1,31 @@
+const Command = require('../../Command');
+const yargs = require('yargs');
+const _ = require('lodash');
+const { sdk } = require('../../../../logic');
+
+const approveBuildCmd = new Command({
+    root: true,
+    command: 'approve <buildId>',
+    description: 'Approve a pending-approval workflow',
+    usage: 'approve <$BUILD_ID>',
+    webDocs: {
+        category: 'Builds',
+        title: 'Approve',
+        weight: 100,
+    },
+    builder: (yargs) => {
+        return yargs
+            .positional('buildId', {
+                describe: 'Build\'s id',
+                required: true,
+            });
+    },
+    handler: async (argv) => {
+        const { buildId } = argv;
+        await sdk.workflows.get({ id: buildId });
+        await sdk.workflows.approve({ buildId });
+        console.log(`Workflow ${buildId} has been approved.`);
+    },
+});
+
+module.exports = approveBuildCmd;

lib/interface/cli/commands/workflow/approve.cmd.spec.js

@@ -0,0 +1,47 @@
+let approveCmd = require('./approve.cmd');
+
+approveCmd.requiresAuthentication = false;
+
+approveCmd = approveCmd.toCommand();
+
+
+jest.mock('../../helpers/validation', () => { // eslint-disable-line
+    return {
+        validatePipelineSpec: () => ({ valid: true }),
+    };
+});
+
+const request = require('requestretry');
+
+const DEFAULT_RESPONSE = request.__defaultResponse();
+
+describe('Approve pending-approval workflow', () => {
+    beforeEach(async () => {
+        request.__reset();
+        request.mockClear();
+        await configureSdk(); // eslint-disable-line
+    });
+
+    describe('Positive', () => {
+        it('should approve a pending-approval workflow', async () => {
+            const argv = {
+                buildId: 'buildId',
+            };
+            const response = { statusCode: 200, body: [DEFAULT_RESPONSE.body] };
+            request.__setResponse(response);
+            await approveCmd.handler(argv);
+            await verifyResponsesReturned([response, response]); // eslint-disable-line
+        });
+    });
+
+    describe('Negative', () => {
+        it('should approve a pending-approval workflow', async () => {
+            const argv = {
+                buildId: 'buildId',
+            };
+            const response = { statusCode: 404, body: [DEFAULT_RESPONSE.body] };
+            request.__setResponse(response);
+            await expect(approveCmd.handler(argv)).rejects.toThrow();
+        });
+    });
+});

lib/interface/cli/commands/workflow/deny.cmd.js

@@ -0,0 +1,31 @@
+const Command = require('../../Command');
+const yargs = require('yargs');
+const _ = require('lodash');
+const { sdk } = require('../../../../logic');
+
+const denyBuildCmd = new Command({
+    root: true,
+    command: 'deny <buildId>',
+    description: 'Deny a pending-approval workflow',
+    usage: 'deny <$BUILD_ID>',
+    webDocs: {
+        category: 'Builds',
+        title: 'Deny',
+        weight: 100,
+    },
+    builder: (yargs) => {
+        return yargs
+            .positional('buildId', {
+                describe: 'Build\'s id',
+                required: true,
+            });
+    },
+    handler: async (argv) => {
+        const { buildId } = argv;
+        await sdk.workflows.get({ id: buildId });
+        await sdk.workflows.deny({ buildId });
+        console.log(`Workflow ${buildId} has been denied.`);
+    },
+});
+
+module.exports = denyBuildCmd;

lib/interface/cli/commands/workflow/deny.cmd.spec.js

@@ -0,0 +1,47 @@
+let denyCmd = require('./deny.cmd');
+
+denyCmd.requiresAuthentication = false;
+
+denyCmd = denyCmd.toCommand();
+
+
+jest.mock('../../helpers/validation', () => { // eslint-disable-line
+    return {
+        validatePipelineSpec: () => ({ valid: true }),
+    };
+});
+
+const request = require('requestretry');
+
+const DEFAULT_RESPONSE = request.__defaultResponse();
+
+describe('Deny pending-approval workflow', () => {
+    beforeEach(async () => {
+        request.__reset();
+        request.mockClear();
+        await configureSdk(); // eslint-disable-line
+    });
+
+    describe('Positive', () => {
+        it('should deny a pending-approval workflow', async () => {
+            const argv = {
+                buildId: 'buildId',
+            };
+            const response = { statusCode: 200, body: [DEFAULT_RESPONSE.body] };
+            request.__setResponse(response);
+            await denyCmd.handler(argv);
+            await verifyResponsesReturned([response, response]); // eslint-disable-line
+        });
+    });
+
+    describe('Negative', () => {
+        it('should deny a pending-approval workflow', async () => {
+            const argv = {
+                buildId: 'buildId',
+            };
+            const response = { statusCode: 404, body: [DEFAULT_RESPONSE.body] };
+            request.__setResponse(response);
+            await expect(denyCmd.handler(argv)).rejects.toThrow();
+        });
+    });
+});

lib/interface/cli/commands/workflow/workflow.sdk.spec.js

@@ -39,6 +39,7 @@ describe('workflow commands', () => {
             const argv = { id: ['some id'] };
             const response = { statusCode: 200, body: [DEFAULT_RESPONSE.body] };
             request.__setResponse(response);
+
             await getCmd.handler(argv);
             await verifyResponsesReturned([response]); // eslint-disable-line
         });

openapi.json

@@ -6588,6 +6588,60 @@
         "summary": "Get server version",
         "x-sdk-interface": "version.getServerVersion"
       }
+    },
+    "/workflow/{buildId}/pending-approval/approve": {
+      "get": {
+        "responses": {
+          "200": {
+            "description": "ok"
+          }
+        },
+        "tags": [
+          "workflow",
+          "build",
+          "approve"
+        ],
+        "parameters": [
+          {
+            "in": "path",
+            "name": "buildId",
+            "schema": {
+              "type": "string"
+            },
+            "required": true
+          }
+        ],
+        "operationId": "workflow-approve",
+        "summary": "Approve a pending-approval workflow",
+        "x-sdk-interface": "workflows.approve"
+      }
+    },
+    "/workflow/{buildId}/pending-approval/deny": {
+      "get": {
+        "responses": {
+          "200": {
+            "description": "ok"
+          }
+        },
+        "tags": [
+          "workflow",
+          "build",
+          "deny"
+        ],
+        "parameters": [
+          {
+            "in": "path",
+            "name": "buildId",
+            "schema": {
+              "type": "string"
+            },
+            "required": true
+          }
+        ],
+        "operationId": "workflow-deny",
+        "summary": "Deny a pending-approval workflow",
+        "x-sdk-interface": "workflows.deny"
+      }
     }
   },
   "components": {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "codefresh",
-  "version": "0.19.7",
+  "version": "0.20.0",
   "description": "Codefresh command line utility",
   "main": "index.js",
   "preferGlobal": true,