SAAS-7564 - fix downloading venona release with no assets (#507)

Author: roi-codefresh

lib/binary/downloader.js

@@ -28,16 +28,28 @@ function _ensureDirectory(location) {
 }
 
 async function _getRemoteVersion({
-    name, branch, path, file,
+    name, osType,
 }) {
-    const final = branch ? `${name}/${branch}/${path}` : `${name}/${path}`;
-    const url = `https://raw.githubusercontent.com/codefresh-io/${final}/${file}`;
-    const req = await rp({
-        url,
+    // get the 10 latest releases
+    const releasesUrl = `https://api.github.com/repos/codefresh-io/${name}/releases?per_page=10`;
+    const res = await rp({
+        uri: releasesUrl,
         method: 'GET',
         headers: { 'User-Agent': 'codefresh' },
     });
-    return req;
+
+    const releases = JSON.parse(res);
+    for (let i = 0; i < releases.length; i += 1) {
+        const curRelease = releases[i];
+        const neededAsset = (curRelease.assets || []).find(asset => { 
+            const assetName = asset.name || '';
+            return assetName.startsWith(`${name}_`) && assetName.endsWith(osType);
+        });
+        if (neededAsset) {
+            return { remoteVersion: curRelease.name, download_url: neededAsset.browser_download_url };
+        }
+    }
+    return { remoteVersion: '0', download_url: '' };
 }
 
 function _buildDownloadURL({ name, version, binary }) {
@@ -106,25 +118,18 @@ class Downloader {
 
         let localVersion = _getLocalVersion(join(dir, component.local.versionFile));
         const {
-            repo: name, branch, versionPath: path, versionFile: file,
+            repo: name,
         } = component.remote;
-        let remoteVersion = await _getRemoteVersion({
-            name, branch, path, file,
-        });
+        let { remoteVersion, download_url } = await _getRemoteVersion({ name, osType });
         remoteVersion = remoteVersion.trim();
         localVersion = localVersion.trim();
 
         if (compareVersions(localVersion, remoteVersion) >= 0) {
-            // logger.debug(`Download is not required latest-version=${remoteVersion} local-version=${localVersion}`);
             return Promise.resolve();
         }
-        logger.debug(`${component.name} component upgrade is required, downloading.`);
-
+        logger.debug(`${component.name} component upgrade is required, downloading latest version [${remoteVersion}]`);
 
-        const binary = `${name}_${remoteVersion}_${osType}`;
-        const version = component.version.prefix ? `${component.version.prefix}${remoteVersion}` : remoteVersion;
-        const url = _buildDownloadURL({ name, version, binary });
-        const resp = await request(url);
+        const resp = await request(download_url);
 
         if (this.progress) {
             let size = 0;