SAAS-4712 #time 2h 10m Made some small refactoring (#378)

* SAAS-4712 #time 2h 10m Made some small refactoring - moved checking existing project to the helper.

* rebuild

Co-authored-by: Denis Melnik <[email protected]>

Author: olegz-codefresh

lib/interface/cli/commands/project/create.cmd.js

@@ -3,7 +3,8 @@ const CFError = require('cf-errors');
 const _ = require('lodash');
 const { sdk } = require('../../../../logic');
 const createRoot = require('../root/create.cmd');
-const { prepareKeyValueObjectsFromCLIEnvOption, ignoreHttpError } = require('../../helpers/general');
+const { checkOrProjectExists } = require('../../helpers/validation');
+const { prepareKeyValueObjectsFromCLIEnvOption } = require('../../helpers/general');
 
 const command = new Command({
     command: 'project <name>',
@@ -60,11 +61,7 @@ const command = new Command({
             variable.encrypted = true;
         });
 
-        const existing = await sdk.projects.getByName({ name: projectName }).catch(ignoreHttpError); // ignore not found error
-        if (existing) {
-            throw new CFError(`Project already exists: "${projectName}"`);
-        }
-
+        await checkOrProjectExists(projectName);
         await sdk.projects.create({ projectName, tags, variables });
         console.log(`Project: "${projectName}" created`);
     },

lib/interface/cli/helpers/validation.js

@@ -1,7 +1,8 @@
 const _ = require('lodash');
 const yaml = require('js-yaml');
-const { readFile } = require('./general');
+const { readFile, ignoreHttpError } = require('./general');
 const { sdk } = require('../../../logic');
+const CFError = require('cf-errors');
 
 
 function _buildFinalMessage(baseMessage, validationResult) {
@@ -46,7 +47,15 @@ async function validatePipelineYaml(filename, fileContent) {
     return { valid: !!result.valid, message };
 }
 
+async function checkOrProjectExists(projectName) {
+    const existing = await sdk.projects.getByName({ name: projectName }).catch(ignoreHttpError); // ignore not found error
+    if (existing) {
+        throw new CFError(`Project already exists: "${projectName}"`);
+    }
+}
+
 module.exports = {
     validatePipelineSpec,
     validatePipelineYaml,
+    checkOrProjectExists,
 };

lib/logic/index.js

@@ -3,3 +3,4 @@ const sdk = require('./sdk');
 module.exports = {
     sdk,
 };
+

package.json

@@ -1,6 +1,6 @@
 {
   "name": "codefresh",
-  "version": "0.39.0",
+  "version": "0.39.1",
   "description": "Codefresh command line utility",
   "main": "index.js",
   "preferGlobal": true,