Saas 4713 (#425)

pasha-codefresh · radiosource · web-flow · commit 2a7376581701 · 2020-03-20T12:17:07.000+02:00
* [other] - added flag `--all` for getting pipelines without limit (in such cases, actually limit of 10k)

* [other] - chamged &gt;-1 to &gt;=0

* [other] - v up

* bump version

* support test/delete/rollback

* support test/delete/rollback

* support test/delete/rollback

* support test/delete/rollback

Co-authored-by: zagnit &lt;riftersound@gmail.com&gt;
diff --git a/lib/interface/cli/commands/helm/release/delete-release.cmd.js b/lib/interface/cli/commands/helm/release/delete-release.cmd.js
@@ -2,6 +2,7 @@ const Command = require('../../../Command');
 const { sdk } = require('../../../../../logic');
 const { followLogs } = require('../../../helpers/logs');
 const Output = require('../../../../../output/Output');
+const helmUtil = require('./util');
 
 const install = new Command({
     root: true,
@@ -43,11 +44,17 @@ const install = new Command({
                 alias: 'nh',
             })
             .option('tiller-namespace', {
-                description: 'prevent hooks from running during deletion',
+                description: 'namespace where is tiller running ( helm 2 only )',
                 type: 'string',
                 alias: 'n',
                 default: 'kube-system',
             })
+            .option('namespace', {
+                description: 'namespace where is chart located ( helm 3 )',
+                type: 'string',
+                alias: 'ns',
+                default: 'default',
+            })
             .example('codefresh delete-release my-release --cluster my-cluster', 'Delete release "my-release" from cluster "my-cluster"');
     },
     handler: async (argv) => {
@@ -57,18 +64,21 @@ const install = new Command({
             noHooks,
             timeout,
             cluster,
-            tillerNamespace,
+            'tiller-namespace': tillerNamespace,
+            namespace,
         } = argv;
 
         if (!releaseName) {
             throw new Error('Release name is required');
         }
 
         try {
+            const ns = (await helmUtil.isHelm3(cluster)) ? namespace : tillerNamespace;
+
             const result = await sdk.helm.releases.delete({
                 releaseName,
                 selector: cluster,
-                tillerNamespace,
+                tillerNamespace: ns,
             }, {
                 purge,
                 timeout,
diff --git a/lib/interface/cli/commands/helm/release/helm-releases.sdk.spec.js b/lib/interface/cli/commands/helm/release/helm-releases.sdk.spec.js
@@ -44,6 +44,7 @@ describe('helm-release commands', () => {
                 cleanup: true,
                 timeout: 300,
                 cluster: 'cluster',
+                tillerNamespace: 'tillerNamespace',
             };
             await testCmd.handler(argv);
             await verifyResponsesReturned([DEFAULT_RESPONSE]); // eslint-disable-line
diff --git a/lib/interface/cli/commands/helm/release/rollback-release.cmd.js b/lib/interface/cli/commands/helm/release/rollback-release.cmd.js
@@ -0,0 +1,87 @@
+const Command = require('../../../Command');
+const { sdk } = require('../../../../../logic');
+const { followLogs } = require('../../../helpers/logs');
+const Output = require('../../../../../output/Output');
+const helmUtil = require('./util');
+
+const rollback = new Command({
+    root: true,
+    command: 'rollback-release <name>',
+    description: 'Rollback a helm release from a kubernetes cluster',
+    webDocs: {
+        category: 'Predefined Pipelines',
+        title: 'Rollback Helm Release',
+        weight: 10,
+    },
+    builder: (yargs) => {
+        return yargs
+            .option('cluster', {
+                description: 'Run on cluster',
+                type: 'string',
+                required: true,
+                alias: 'c',
+            })
+            .option('revision', {
+                description: 'revision number',
+                type: 'number',
+                alias: 't',
+                required: true,
+            })
+            .option('tiller-namespace', {
+                description: 'prevent hooks from running during deletion',
+                type: 'string',
+                alias: 'n',
+                default: 'kube-system',
+            })
+            .option('namespace', {
+                description: 'prevent hooks from running during deletion',
+                type: 'string',
+                alias: 'ns',
+                default: 'default',
+            })
+            .option('detach', {
+                alias: 'd',
+                describe: 'Run pipeline and print build ID',
+            })
+            .example('codefresh rollback my-release --cluster my-cluster --revision 1',
+                'rollback release "my-release" from cluster "my-cluster"');
+    },
+    handler: async (argv) => {
+        const {
+            name: releaseName,
+            revision,
+            cluster: selector,
+            tillerNamespace,
+            namespace,
+        } = argv;
+
+        if (!releaseName) {
+            throw new Error('Release name is required');
+        }
+
+        try {
+            const ns = (await helmUtil.isHelm3(selector)) ? namespace : tillerNamespace;
+
+            const result = await sdk.kubernetes.rollback({
+                release: releaseName,
+                selector,
+                tillerNamespace: ns,
+                revision,
+            });
+
+            const workflowId = result.id;
+
+            if (argv.detach) {
+                console.log(workflowId);
+                return;
+            }
+            const exitCode = await followLogs(workflowId);
+            process.exit(exitCode);
+        } catch (err) {
+            Output.printError(err);
+            process.exit(1);
+        }
+    },
+});
+
+module.exports = rollback;
diff --git a/lib/interface/cli/commands/helm/release/test-release.cmd.js b/lib/interface/cli/commands/helm/release/test-release.cmd.js
@@ -2,6 +2,7 @@ const Command = require('../../../Command');
 const { followLogs } = require('../../../helpers/logs');
 const { sdk } = require('../../../../../logic');
 const Output = require('../../../../../output/Output');
+const helmUtil = require('./util');
 
 const install = new Command({
     root: true,
@@ -24,6 +25,18 @@ const install = new Command({
                 type: 'string',
                 required: true,
             })
+            .option('tiller-namespace', {
+                description: 'namespace where is tiller running ( helm 2 only )',
+                type: 'string',
+                alias: 'n',
+                default: 'kube-system',
+            })
+            .option('namespace', {
+                description: 'namespace where is chart located ( helm 3 )',
+                type: 'string',
+                alias: 'ns',
+                default: 'default',
+            })
             .option('timeout', {
                 description: 'time in seconds to wait for any individual kubernetes operation (like Jobs for hooks) (default 300)',
                 default: '300',
@@ -45,14 +58,19 @@ const install = new Command({
             cluster,
             cleanup,
             timeout,
+            'tiller-namespace': tillerNamespace,
+            namespace,
         } = argv;
         if (!releaseName) {
             throw new Error('Release name is required');
         }
         try {
+            const ns = (await helmUtil.isHelm3(cluster)) ? namespace : tillerNamespace;
+
             const result = await sdk.helm.releases.test({
                 releaseName,
                 selector: cluster,
+                tillerNamespace: ns,
             }, {
                 cleanup,
                 timeout,
diff --git a/lib/interface/cli/commands/helm/release/util.js b/lib/interface/cli/commands/helm/release/util.js
@@ -0,0 +1,16 @@
+const { sdk } = require('../../../../../logic');
+
+class HelmUtil {
+    // eslint-disable-next-line class-methods-use-this
+    async isHelm3(cluster) {
+        try {
+            const config = await sdk.helm['cluster-config'].get({
+                selector: cluster,
+            });
+            return config.helmVersion === 'helm3';
+        } catch (e) {
+            return false;
+        }
+    }
+}
+module.exports = new HelmUtil();
diff --git a/openapi.json b/openapi.json
@@ -1633,7 +1633,6 @@
         "x-sdk-interface": "onPrem.runtimeEnvs.plan.get"
       }
     },
-
     "/pipelines/analyze": {
       "post": {
         "responses": {
@@ -1653,6 +1652,32 @@
         "x-sdk-interface": "pipelines.analyze"
       }
     },
+    "/helm/cluster-config/{selector}": {
+      "get": {
+        "responses": {
+          "200": {
+            "$ref": "#/components/responses/Json"
+          }
+        },
+        "tags": [
+          "helm.cluster-config"
+        ],
+        "operationId": "helm-cluster-config-get",
+        "parameters": [
+          {
+            "in": "path",
+            "name": "selector",
+            "description": "Cluster selector",
+            "schema": {
+              "type": "string"
+            },
+            "required": true
+          }
+        ],
+        "summary": "Get cluster config",
+        "x-sdk-interface": "helm.cluster-config.get"
+      }
+    },
 
     "/annotations": {
       "delete": {
@@ -5125,8 +5150,7 @@
             "name": "tillerNamespace",
             "schema": {
               "type": "string"
-            },
-            "required": true
+            }
           }
         ],
         "requestBody": {
@@ -5142,6 +5166,73 @@
         "x-sdk-interface": "helm.releases.delete"
       }
     },
+    "/kubernetes/rollback/{release}/{revision}": {
+      "get": {
+        "responses": {
+          "200": {
+            "description": "id of pipeline with rollback",
+            "content": {
+              "application/json": {
+                "schema": {
+                  "type": "object",
+                  "properties": {
+                    "id": {
+                      "type": "string"
+                    }
+                  }
+                }
+              }
+            }
+          }
+        },
+        "tags": [
+          "kubernetes"
+        ],
+        "operationId": "kubernetes-rollback-release",
+        "parameters": [
+          {
+            "in": "path",
+            "name": "release",
+            "schema": {
+              "type": "string"
+            },
+            "description": "release",
+            "required": true
+          },
+          {
+            "in": "path",
+            "name": "revision",
+            "schema": {
+              "type": "string"
+            },
+            "description": "revision",
+            "required": true
+          },
+          {
+            "in": "query",
+            "name": "selector",
+            "schema": {
+              "type": "string"
+            },
+            "description": "Selector"
+          },
+          {
+            "in": "query",
+            "name": "tillerNamespace",
+            "schema": {
+              "type": "string"
+            },
+            "required": true,
+            "description": "Tiller namespace"
+          }
+        ],
+        "requestBody": {
+          "$ref": "#/components/requestBodies/Json"
+        },
+        "summary": "Rollback",
+        "x-sdk-interface": "kubernetes.rollback"
+      }
+    },
     "/kubernetes/releases/{releaseName}/test": {
       "post": {
         "responses": {
@@ -5168,6 +5259,13 @@
             "schema": {
               "type": "string"
             }
+          },
+          {
+            "in": "query",
+            "name": "tillerNamespace",
+            "schema": {
+              "type": "string"
+            }
           }
         ],
         "requestBody": {
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "codefresh",
-  "version": "0.43.15",
+  "version": "0.43.16",
   "description": "Codefresh command line utility",
   "main": "index.js",
   "preferGlobal": true,

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "codefresh",`
`3`		`- "version": "0.43.15",`
	`3`	`+ "version": "0.43.16",`
`4`	`4`	`"description": "Codefresh command line utility",`
`5`	`5`	`"main": "index.js",`
`6`	`6`	`"preferGlobal": true,`