prevent runtime name collision (#469)

Author: roi-codefresh

lib/interface/cli/commands/runtimeEnvironments/install.cmd.js

@@ -8,9 +8,28 @@ const ProgressEvents = require('../../helpers/progressEvents');
 const cliProgress = require('cli-progress');
 const createClusterCmd = require('../cluster/create.cmd');
 const colors = require('colors');
+const _ = require('lodash');
 
 const defaultNamespace = 'codefresh';
 
+async function newRuntimeName(kubeContextName, kubeNamespace) {
+    const defaultName = `${kubeContextName}/${kubeNamespace}`;
+    const runtimes = await sdk.runtimeEnvs.list({ });
+    let name;
+
+    if (!_.isArray(runtimes) || !_.find(runtimes, re => _.get(re, 'metadata.name') === defaultName)) {
+        name = defaultName; // use the default name if there are no collisions
+    } else {
+        const reNames = new Set(_.map(runtimes, re => _.get(re, 'metadata.name'))); // for fast lookup
+        let i = 1;
+        while (reNames.has(`${defaultName}_${i}`)) {
+            i += 1;
+        }
+        name = `${defaultName}_${i}`;
+    }
+
+    return name;
+}
 const installRuntimeCmd = new Command({
     root: false,
     parent: installRoot,
@@ -143,7 +162,7 @@ const installRuntimeCmd = new Command({
             kubeContextName = getKubeContext(kubeConfigPath);
         }
         const clusterName = kubeContextName || getKubeContext(kubeConfigPath);
-        const runtimeName = `${clusterName}/${kubeNamespace}`;
+        const runtimeName = await newRuntimeName(kubeContextName, kubeNamespace);
 
         if (!token) {
             // eslint-disable-next-line prefer-destructuring
@@ -158,6 +177,7 @@ const installRuntimeCmd = new Command({
             nodeSelector: kubeNodeSelectorObj,
             annotations: buildAnnotations,
             clusterName,
+            runtimeName,
             agent: true,
         });
         console.log(`Runtime environment "${colors.cyan(runtimeName)}" has been created`);