Saas-7187 prevent agent name collisions (#460)

Author: roi-codefresh

lib/interface/cli/commands/agent/install.cmd.js

@@ -7,9 +7,29 @@ const { getKubeContext } = require('../../helpers/kubernetes');
 const ProgressEvents = require('../../helpers/progressEvents');
 const cliProgress = require('cli-progress');
 const colors = require('colors');
+const _ = require('lodash');
 
 const defaultNamespace = 'codefresh';
 
+async function newAgentName(kubeContextName, kubeNamespace) {
+    const defaultName = `${kubeContextName}_${kubeNamespace}`;
+    const agents = await sdk.agents.list({ });
+    let name;
+
+    if (!_.isArray(agents) || !_.find(agents, a => a.name === defaultName)) {
+        name = defaultName; // use the default name if there are no collisions
+    } else {
+        const agentsNames = new Set(_.map(agents, a => a.name)); // for fast lookup
+        let i = 1;
+        while (agentsNames.has(`${defaultName}_${i}`)) {
+            i += 1;
+        }
+        name = `${defaultName}_${i}`;
+    }
+
+    return name;
+}
+
 const installAgentCmd = new Command({
     root: false,
     parent: installRoot,
@@ -102,7 +122,7 @@ const installAgentCmd = new Command({
         }
 
         if (!token) { // Create an agent if not provided
-            name = name || `${kubeContextName}_${kubeNamespace}`;
+            name = name || await newAgentName(kubeContextName, kubeNamespace);
             agent = await sdk.agents.create({ name });
             // eslint-disable-next-line prefer-destructuring
             token = agent.token;

package.json

@@ -1,6 +1,6 @@
 {
   "name": "codefresh",
-  "version": "0.62.0",
+  "version": "0.62.3",
   "description": "Codefresh command line utility",
   "main": "index.js",
   "preferGlobal": true,