* goog.string/contains does work, add test

* remove hint from NaN?
* FIXME note about re-matches

Author: swannodette

src/main/cljs/cljs/core.cljs

@@ -12273,7 +12273,7 @@ reduces them without incurring seq initialization"
   (when (nil? NS_CACHE)
     (set! NS_CACHE (atom {})))
   (let [ns-str (str_ ns)
-        ns (if (not ^boolean (gstring/contains ns-str "$macros"))
+        ns (if (not (gstring/contains ns-str "$macros"))
              (symbol (str_ ns-str "$macros"))
              ns)
         the-ns (get @NS_CACHE ns)]
@@ -12297,7 +12297,7 @@ reduces them without incurring seq initialization"
   [x]
   (instance? goog.Uri x))
 
-(defn ^boolean NaN?
+(defn NaN?
   "Returns true if num is NaN, else false"
   [val]
   (js/isNaN val))
@@ -12326,6 +12326,7 @@ reduces them without incurring seq initialization"
   [s]
   (if (string? s)
     (cond
+      ;; FIXME: another cases worth thinking about
       ^boolean (re-matches #"[\x00-\x20]*[+-]?NaN[\x00-\x20]*" s) ##NaN
       ^boolean (re-matches
                 #"[\x00-\x20]*[+-]?(Infinity|((\d+\.?\d*|\.\d+)([eE][+-]?\d+)?)[dDfF]?)[\x00-\x20]*"

src/test/clojure/cljs/compiler_tests.clj

@@ -382,6 +382,15 @@
                    '[(if (.isNaN js/Number 1) true false)]))]
       (is (nil? (re-find #"truth_" code))))))
 
+(deftest test-goog-lib-infer-boolean
+  (testing "Can infer goog.string/contains returns boolean"
+    (let [code (env/with-compiler-env (env/default-compiler-env)
+                 (compile-form-seq
+                   '[(ns test.foo
+                       (:require [goog.string :as gstring]))
+                     (if (gstring/contain "foobar" "foo") true false)]))]
+      (is (nil? (re-find #"truth_" code))))))
+
 ;; CLJS-1225
 
 (comment

src/test/clojure/cljs/type_inference_tests.clj

@@ -395,14 +395,22 @@
                  (Html5History.)]
                {} true))))))
 
-;; FIXME: infers any instead of boolean, nothing wrong w/ the externs parsing
-;; but this definitely does not work at the moment
-#_(deftest test-goog-infer
+(deftest test-goog-infer
   (is (= 'boolean
+        (:tag (env/with-compiler-env (env/default-compiler-env)
+                (ana/analyze-form-seq
+                  '[(ns test.foo
+                      (:require [goog.string :as gstring]))
+                    (gstring/contains "foobar" "foo")]
+                  {} true)))))
+  ;; FIXME: infers any instead of boolean, nothing wrong w/ the externs parsing
+  ;; but this definitely does not work at the moment
+  #_(is (= 'boolean
         (:tag
           (env/with-compiler-env (env/default-compiler-env)
             (ana/analyze-form-seq
               '[(ns test.foo
                   (:require [goog.object :as gobject]))
                 (gobject/containsKey (js-object) "foo")]
               {} true))))))
+