Fix assumption that all closure-compliant JS is goog.*

When using other Closure-compatible JS libs the compiler would
otherwise try to emit CLJS-styles invokes.

Expected:
somefn(1)
Actual:
somefn.cljs$core$IFn$_invoke$arity$1 ? ... : somefn.call(null, 1)

This is a CLJS idiom and should only be emitted if we have
analyzer data for the given namespace.

Author: thheller

src/main/clojure/cljs/compiler.cljc

@@ -951,7 +951,9 @@
         goog? (when ns
                 (or (= ns 'goog)
                     (when-let [ns-str (str ns)]
-                      (= (get (string/split ns-str #"\.") 0 nil) "goog"))))
+                      (= (get (string/split ns-str #"\.") 0 nil) "goog"))
+                    (not (contains? (::ana/namespaces @env/*compiler*) ns))))
+
         keyword? (and (= (-> f :op) :constant)
                       (keyword? (-> f :form)))
         [f variadic-invoke]

src/test/cljs/cljs/invoke_test.cljs

@@ -0,0 +1,16 @@
+(ns cljs.invoke-test
+  (:require [goog.string :as gstr]))
+
+(defn variadic-fn [& args])
+
+(variadic-fn 1 2 3)
+
+(defn multi-fn
+  ([a] a)
+  ([a b] a))
+
+(multi-fn 2)
+
+(gstr/urlEncode "foo")
+
+(js/goog.string.urlDecode "bar")

src/test/clojure/cljs/compiler_tests.clj

@@ -10,9 +10,12 @@
   (:use clojure.test)
   (:require [cljs.analyzer :as ana]
             [cljs.compiler :as comp]
+            [cljs.compiler.api :as comp-api]
             [cljs.env :as env]
             [cljs.util :as util]
-            [cljs.tagged-literals :as tags])
+            [cljs.tagged-literals :as tags]
+            [clojure.java.io :as io]
+            [clojure.string :as str])
   (:import [java.io File]))
 
 (def aenv (assoc-in (ana/empty-env) [:ns :name] 'cljs.user))
@@ -215,6 +218,28 @@
                           opts
                           (fn [] (ana/analyze aenv specify-test-code nil opts))))))))))))
 
+
+(deftest test-optimized-invoke-emit
+  (let [out-file
+        (io/file "target/invoke_test.js")]
+    (comp-api/with-core-cljs
+      (comp-api/compile-file
+        (io/file "src/test/cljs/cljs/invoke_test.cljs")
+        out-file
+        {:static-fns true}))
+
+    (let [content (slurp out-file)]
+      ;; test for fn( not fn.call(, omitting arguments in test because they are not relevant
+      ;; should emit variadic invokes
+      (is (str/includes? content "cljs.invoke_test.variadic_fn.cljs$core$IFn$_invoke$arity$variadic("))
+      ;; should emit optimized invokes
+      (is (str/includes? content "cljs.invoke_test.multi_fn.cljs$core$IFn$_invoke$arity$1("))
+      ;; closure js code must never use .call(
+      (is (str/includes? content "goog.string.urlEncode("))
+      ;; js/goog.string.urlDecode should not use .call
+      (is (str/includes? content "goog.string.urlDecode(")))
+    ))
+
 ;; CLJS-1225
 
 (comment