Skip to content

Commit 41fc128

Browse files
committed
* remove hints for isFinite and isSafeInteger, tests
1 parent 191798a commit 41fc128

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

src/main/cljs/cljs/core.cljs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1055,8 +1055,8 @@
10551055
(bit-xor (-hash o) 0)
10561056

10571057
(number? o)
1058-
(if ^boolean (js/isFinite o)
1059-
(if-not ^boolean (.isSafeInteger js/Number o)
1058+
(if (js/isFinite o)
1059+
(if-not (.isSafeInteger js/Number o)
10601060
(hash-double o)
10611061
(js-mod (Math/floor o) 2147483647))
10621062
(case o

src/test/clojure/cljs/externs_infer_tests.clj

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,16 @@
183183
(-> (binding [ana/*cljs-ns* ana/*cljs-ns*]
184184
(env/with-compiler-env (env/default-compiler-env)
185185
(analyze (ana/empty-env) '(.isArray js/Array (array)))))
186+
:tag)))
187+
(is (= 'boolean
188+
(-> (binding [ana/*cljs-ns* ana/*cljs-ns*]
189+
(env/with-compiler-env (env/default-compiler-env)
190+
(analyze (ana/empty-env) '(.isSafeInteger js/Number 1))))
191+
:tag)))
192+
(is (= 'boolean
193+
(-> (binding [ana/*cljs-ns* ana/*cljs-ns*]
194+
(env/with-compiler-env (env/default-compiler-env)
195+
(analyze (ana/empty-env) '(js/isFinite 1))))
186196
:tag))))
187197

188198
(deftest test-externs-infer

0 commit comments

Comments
 (0)