Skip to content

Commit 055f39b

Browse files
mfikesswannodette
authored andcommitted
CLJS-2122: Self-host: Non-symbol ns names dumped into env
1 parent a6ff1a7 commit 055f39b

File tree

2 files changed

+27
-1
lines changed

2 files changed

+27
-1
lines changed

src/main/cljs/cljs/js.cljs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -924,7 +924,8 @@
924924
(when (:source-map opts)
925925
(append-source-map env/*compiler*
926926
aname source sb @comp/*source-map-data* opts))
927-
(ana/dump-specs aname)
927+
(when (symbol? aname)
928+
(ana/dump-specs aname))
928929
(let [js-source (.toString sb)
929930
evalm {:lang :clj
930931
:name name

src/test/self/self_host/test.cljs

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -891,6 +891,31 @@
891891
(is (nil? error))
892892
(inc! l))))))
893893

894+
(deftest test-cljs-2122
895+
(async done
896+
(let [st (cljs/empty-state)
897+
l (latch 2 done)]
898+
(cljs/eval-str
899+
st
900+
"1"
901+
nil
902+
{:context :expr
903+
:eval node-eval}
904+
(fn [{:keys [error] :as m}]
905+
(is (nil? error))
906+
(is (every? symbol? (keys (get-in @st [:cljs.analyzer/namespaces]))))
907+
(inc! l)))
908+
(cljs/eval-str
909+
st
910+
"1"
911+
"A string name"
912+
{:context :expr
913+
:eval node-eval}
914+
(fn [{:keys [error] :as m}]
915+
(is (nil? error))
916+
(is (every? symbol? (keys (get-in @st [:cljs.analyzer/namespaces]))))
917+
(inc! l))))))
918+
894919
(defn -main [& args]
895920
(run-tests))
896921

0 commit comments

Comments
 (0)