Skip to content

Commit 246c229

Browse files
committed
Update orchard.java header comments
enrich-classpath supersedes some of these observations.
1 parent c63b12c commit 246c229

File tree

1 file changed

+2
-12
lines changed

1 file changed

+2
-12
lines changed

src/orchard/java.clj

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -28,19 +28,9 @@
2828
;; this simply entails having the corresponding source artifacts in the
2929
;; project's dev dependencies. The core Java API classes are the exception to
3030
;; this, since these are external to lein/maven dependency management. For
31-
;; these, we search the JDK directory and add the source classpath entry
31+
;; these, `enrich-classpath` searches the JDK directory and add the source classpath entry
3232
;; manually, if available. Prior to JDK9, parsing source files also requires
33-
;; having `tools.jar` on the classpath, which we'll have to add as well.
34-
;;
35-
;; The context classloader may be different at startup and in a
36-
;; REPL (e.g. nREPL) session, and these classloaders may not share a modifiable
37-
;; ancestor classloader. That's why the current implementation checks that the
38-
;; JDK sources are visible on the classpath prior to invoking the Java parser,
39-
;; and if not, adds a classpath entry for them. (see `ensure-jdk-sources`)
40-
;;
41-
;; An alternative approach would be to pass the REPL's classloader to Orchard's
42-
;; functions that modify the classpath. You can find a more extensive discussion
43-
;; on that topic here https://github.com/clojure-emacs/orchard/issues/103.
33+
;; having `tools.jar` on the classpath.
4434

4535
(defn ^:deprecated jdk-find
4636
"Search common JDK path configurations for a specified file name and return a

0 commit comments

Comments
 (0)