Remove unnecessary binding of current message (#736)

The binding is not used within the body expressions, and costs a thread
local binding, producing garbage.  This changes ensures print-stream
produces no memory garbage.

The forking-printer just takes values and forwards them. There is no execution of user code, so it can not possibly use the message in any. print-stream invokes the forking printer flush every 100ms, so the current code produces garbage every 100ms.

Author: hugoduncan

src/cider/nrepl/middleware/out.clj

@@ -10,8 +10,7 @@
   guarantee that the channel that sent the clone message will properly
   handle output replies."
   (:require
-   [cider.nrepl.middleware.util.error-handling :refer [with-safe-transport]]
-   [nrepl.middleware.interruptible-eval :as ieval])
+   [cider.nrepl.middleware.util.error-handling :refer [with-safe-transport]])
   (:import
    [java.io PrintWriter Writer PrintStream OutputStream]
    [java.util TimerTask Timer]))
@@ -34,11 +33,11 @@ Please do not inline; they must not be recomputed at runtime."}
                                                       (case ~type
                                                         :out #'*out*
                                                         :err #'*err*))]
-       (try (binding [ieval/*msg* ~'msg]
-              ~@body)
-            ;; If a channel is faulty, dissoc it.
-            (catch Exception ~'e
-              (unsubscribe-session ~'session))))))
+       (try
+         ~@body
+         ;; If a channel is faulty, dissoc it.
+         (catch Exception ~'e
+           (unsubscribe-session ~'session))))))
 
 (defn- dispatch-string
   ([messages type ^String x]