Skip to content

Commit eca9815

Browse files
devanshuVmware100mik
authored andcommitted
Return from RunWithCancel if cmd is kapp
Signed-off-by: Devanshu <[email protected]>
1 parent 11330d3 commit eca9815

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

cli/pkg/kctrl/cmd/app/release/release_cmd_runner.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,6 @@ func (r ReleaseCmdRunner) Run(cmd *goexec.Cmd) error {
3535
r.ui.PrintHeaderText("Building images and resolving references")
3636
}
3737

38-
if filepath.Base(cmd.Path) == "kapp" {
39-
return nil
40-
}
4138
if filepath.Base(cmd.Path) == "kbld" {
4239
cmd.Args = append(cmd.Args, fmt.Sprintf("--imgpkg-lock-output=%s", r.tempImgLockFilepath))
4340
}
@@ -57,6 +54,10 @@ func (r ReleaseCmdRunner) Run(cmd *goexec.Cmd) error {
5754
}
5855

5956
func (r ReleaseCmdRunner) RunWithCancel(cmd *goexec.Cmd, cancelCh chan struct{}) error {
57+
if filepath.Base(cmd.Path) == "kapp" {
58+
return nil
59+
}
60+
6061
if r.fullOutput {
6162
cmd.Stdout = io.MultiWriter(r.log, cmd.Stdout)
6263
cmd.Stderr = io.MultiWriter(r.log, cmd.Stderr)

0 commit comments

Comments
 (0)