Skip to content

Commit d5e341e

Browse files
committed
fix: tests comment typo
Signed-off-by: imusmanmalik <[email protected]>
1 parent 96b6c33 commit d5e341e

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

pkginstall.yaml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
apiVersion: packaging.carvel.dev/v1alpha1
2+
kind: PackageInstall
3+
metadata:
4+
name: cert-man
5+
namespace: test
6+
spec:
7+
syncPeriod: 10s
8+
packageRef:
9+
refName: cert-manager.community.tanzu.vmware.com
10+
versionSelection:
11+
constraints: 1.6.1
12+
prereleases: {}
13+
serviceAccountName: cert-man-test-sa

test/e2e/kappcontroller/packageinstall_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -864,7 +864,7 @@ spec:
864864
// Create Repo and PackageInstall from YAML
865865
kapp.RunWithOpts([]string{"deploy", "-f", "-", "-a", name}, e2e.RunOpts{StdinReader: strings.NewReader(packageInstallYaml)})
866866

867-
// syncPeriod of the App created via PackageInstall should match to configured value on a global controller level config
867+
// syncPeriod of the App created via PackageInstall should match to default
868868
kubectl.Run([]string{"wait", "--for=condition=ReconcileSucceeded", "pkgi/" + name, "--timeout", "1m"})
869869
kubectl.Run([]string{"wait", "--for=condition=ReconcileSucceeded", "apps/" + name, "--timeout", "1m"})
870870
out := kubectl.Run([]string{"get", fmt.Sprintf("apps/%s", name), "-o", "yaml"})
@@ -932,7 +932,7 @@ spec:
932932
// Create Repo and PackageInstall from YAML
933933
kapp.RunWithOpts([]string{"deploy", "-f", "-", "-a", name}, e2e.RunOpts{StdinReader: strings.NewReader(packageInstallYaml)})
934934

935-
// syncPeriod of the App created via PackageInstall should match to configured value on a global controller level config
935+
// syncPeriod of the App created via PackageInstall should match to configured value part of PackageInstall.
936936
kubectl.Run([]string{"wait", "--for=condition=ReconcileSucceeded", "pkgi/" + name, "--timeout", "1m"})
937937
kubectl.Run([]string{"wait", "--for=condition=ReconcileSucceeded", "apps/" + name, "--timeout", "1m"})
938938
out := kubectl.Run([]string{"get", fmt.Sprintf("apps/%s", name), "-o", "yaml"})

0 commit comments

Comments
 (0)