Ensure that --build-values does not affect package output

Signed-off-by: Soumik Majumder <[email protected]>

Author: 100mik

cli/pkg/kctrl/cmd/app/release/app_spec_builder.go

@@ -65,7 +65,7 @@ func (b *AppSpecBuilder) Build() (kcv1alpha1.AppSpec, error) {
 					Git: &kcv1alpha1.AppFetchGit{},
 				},
 			},
-			Template: b.opts.BuildTemplate,
+			Template: b.deepCopyAppTemplateList(b.opts.BuildTemplate),
 			Deploy:   b.opts.BuildDeploy,
 		},
 	}
@@ -169,3 +169,12 @@ func (b *AppSpecBuilder) checkForErrorsAfterReconciliation(app kcv1alpha1.App, f
 	}
 	return nil
 }
+
+func (b *AppSpecBuilder) deepCopyAppTemplateList(src []kcv1alpha1.AppTemplate) []kcv1alpha1.AppTemplate {
+	copy := []kcv1alpha1.AppTemplate{}
+	for _, templateStep := range src {
+		templateStepCopy := templateStep.DeepCopy()
+		copy = append(copy, *templateStepCopy)
+	}
+	return copy
+}