Skip to content

Commit b6d8c0a

Browse files
committed
updated command description
Signed-off-by: Yash Sethiya <[email protected]>
1 parent c5beb48 commit b6d8c0a

File tree

3 files changed

+6
-9
lines changed

3 files changed

+6
-9
lines changed

.github/workflows/test-kctrl-gh.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,6 @@ jobs:
3434
with:
3535
only: ytt, kbld, imgpkg, vendir, kapp
3636
token: ${{ secrets.GITHUB_TOKEN }}
37-
- name: Login to GitHub Container Registry
38-
uses: docker/login-action@v3
39-
with:
40-
registry: ghcr.io
41-
username: ${{ github.actor }}
42-
password: ${{ secrets.GITHUB_TOKEN }}
4337
- name: Run Tests
4438
run: |
4539
set -e -x

cli/pkg/kctrl/cmd/package/repository/add_or_update.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ func NewAddCmd(o *AddOrUpdateOptions, flagsFactory cmdcore.FlagsFactory) *cobra.
7777

7878
// TODO consider how to support other repository types
7979
cmd.Flags().StringVar(&o.URL, "url", "", "OCI registry url for package repository bundle (required)")
80-
cmd.Flags().StringVar(&o.SemverTagConstraints, "semver-tag-constraints", "", "Mention tag/semver constraint when tag is not present in URL (If both tags and semver are present, then tag gets precedence)")
80+
cmd.Flags().StringVar(&o.SemverTagConstraints, "semver-tag-constraints", "", "tag/semver constraint when tag is not present in URL (If both tags and semver are present, then tag gets precedence)")
8181
cmd.Flags().BoolVar(&o.DryRun, "dry-run", false, "Print YAML for resources being applied to the cluster without applying them, optional")
8282

8383
cmd.Flags().BoolVar(&o.CreateNamespace, "create-namespace", false, "Create the package repository namespace if not present (default false)")
@@ -118,7 +118,7 @@ func NewUpdateCmd(o *AddOrUpdateOptions, flagsFactory cmdcore.FlagsFactory) *cob
118118
}
119119

120120
cmd.Flags().StringVarP(&o.URL, "url", "", "", "OCI registry url for package repository bundle (required)")
121-
cmd.Flags().StringVarP(&o.SemverTagConstraints, "semver-tag-constraints", "", "", "Mention tag/semver constraint when tag is not present in URL (If both tags and semver are present, then tag gets precedence)")
121+
cmd.Flags().StringVarP(&o.SemverTagConstraints, "semver-tag-constraints", "", "", "tag/semver constraint when tag is not present in URL (If both tags and semver are present, then tag gets precedence)")
122122

123123
o.WaitFlags.Set(cmd, flagsFactory, &cmdcore.WaitFlagsOpts{
124124
AllowDisableWait: true,

cli/test/e2e/package_repository_test.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,11 @@
44
package e2e
55

66
import (
7+
"fmt"
78
"testing"
9+
"time"
810

11+
uitest "github.com/cppforlife/go-cli-ui/ui/test"
912
"github.com/stretchr/testify/require"
1013
)
1114

@@ -207,7 +210,7 @@ func TestPackageRepositoryTagSemver(t *testing.T) {
207210
}
208211

209212
cleanUp()
210-
//defer cleanUp()
213+
defer cleanUp()
211214

212215
logger.Section("adding a repository", func() {
213216
kappCtrl.Run([]string{"package", "repository", "add", "-r", pkgrName, "--url", pkgrURL + ":v1.0.0"})

0 commit comments

Comments
 (0)