Fix panic calling tanzu package installed status (#1161)

clebs · web-flow · commit 9a0282f46093 · 2023-04-05T23:21:40.000+05:30
* Fix panic calling tanzu package installed status

Calling tanzu package installed status without any arguments causes the
program to panic.

Signed-off-by: Borja Clemente &lt;cborja@vmware.com&gt;

* Apply review feedback

Signed-off-by: Borja Clemente &lt;cborja@vmware.com&gt;

---------

Signed-off-by: Borja Clemente &lt;cborja@vmware.com&gt;
diff --git a/cli/pkg/kctrl/cmd/package/installed/status.go b/cli/pkg/kctrl/cmd/package/installed/status.go
@@ -61,7 +61,9 @@ func NewStatusCmd(o *StatusOptions, flagsFactory cmdcore.FlagsFactory) *cobra.Co
 
 func (o *StatusOptions) Run(args []string) error {
 	if o.pkgCmdTreeOpts.PositionalArgs {
-		o.Name = args[0]
+		if len(args) > 0 {
+			o.Name = args[0]
+		}
 	}
 
 	if len(o.Name) == 0 {

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,9 @@ func NewStatusCmd(o StatusOptions, flagsFactory cmdcore.FlagsFactory) cobra.Co`
`61`	`61`
`62`	`62`	`func (o *StatusOptions) Run(args []string) error {`
`63`	`63`	`if o.pkgCmdTreeOpts.PositionalArgs {`
`64`		`- o.Name = args[0]`
	`64`	`+ if len(args) > 0 {`
	`65`	`+ o.Name = args[0]`
	`66`	`+ }`
`65`	`67`	`}`
`66`	`68`
`67`	`69`	`if len(o.Name) == 0 {`