chore: Add tests for config and app

Signed-off-by: imusmanmalik <[email protected]>

Author: imusmanmalik

pkg/config/config_test.go

@@ -45,6 +45,36 @@ func Test_NewConfig_ReturnsSecret_WhenBothConfigMapAndSecretExist(t *testing.T)
 	}, config.ProxyOpts())
 }
 
+func Test_NewConfig_PackageInstallDefaultSyncPeriod(t *testing.T) {
+	t.Run("with empty config value, returns 10m", func(t *testing.T) {
+		secret := &v1.Secret{
+			ObjectMeta: metav1.ObjectMeta{
+				Name:      "kapp-controller-config",
+				Namespace: "default",
+			},
+			Data: map[string][]byte{},
+		}
+		config, err := kcconfig.NewConfig(k8sfake.NewSimpleClientset(secret))
+		assert.NoError(t, err)
+		assert.Equal(t, 10*time.Minute, config.PackageInstallDefaultSyncPeriod())
+	})
+
+	t.Run("with value, returns 80s", func(t *testing.T) {
+		secret := &v1.Secret{
+			ObjectMeta: metav1.ObjectMeta{
+				Name:      "kapp-controller-config",
+				Namespace: "default",
+			},
+			Data: map[string][]byte{
+				"packageInstallDefaultSyncPeriod": []byte("80s"),
+			},
+		}
+		config, err := kcconfig.NewConfig(k8sfake.NewSimpleClientset(secret))
+		assert.NoError(t, err)
+		assert.Equal(t, 80*time.Second, config.PackageInstallDefaultSyncPeriod())
+	})
+}
+
 func Test_NewConfig_AppDefaultSyncPeriod(t *testing.T) {
 	t.Run("with empty config value, returns 30s", func(t *testing.T) {
 		secret := &v1.Secret{

pkg/packageinstall/app_test.go

@@ -563,6 +563,78 @@ func TestAppCustomFetchSecretNames(t *testing.T) {
 	require.Equal(t, expectedApp, app, "App does not match expected app")
 }
 
+// TestAppPackageIntallDefaultSyncPeriod tests the creation of an App and expects syncPeriod is set to the default value.
+func TestAppPackageIntallDefaultSyncPeriod(t *testing.T) {
+	ipkg := &pkgingv1alpha1.PackageInstall{
+		ObjectMeta: metav1.ObjectMeta{
+			Name:      "app",
+			Namespace: "default",
+		},
+	}
+
+	pkgVersion := datapkgingv1alpha1.Package{
+		Spec: datapkgingv1alpha1.PackageSpec{
+			RefName: "expec-pkg",
+			Version: "1.5.0",
+			Template: datapkgingv1alpha1.AppTemplateSpec{
+				Spec: &kcv1alpha1.AppSpec{},
+			},
+		},
+	}
+
+	app, err := packageinstall.NewApp(&kcv1alpha1.App{}, ipkg, pkgVersion, packageinstall.Opts{})
+	require.NoError(t, err)
+
+	// Define the expected app object, with the sync period attribute set to the default value
+	expectedApp := &kcv1alpha1.App{
+		Spec: kcv1alpha1.AppSpec{
+			SyncPeriod: packageinstall.DefaultSyncPeriod,
+		},
+	}
+
+	// Not interesting in metadata in this test
+	app.ObjectMeta = metav1.ObjectMeta{}
+
+	require.Equal(t, expectedApp, app, "App does not match expected app")
+}
+
+// TestAppCustomPackageIntallSyncPeriod tests the creation of an App when using PackageInstall with a defined syncPeriod.
+func TestAppCustomPackageIntallSyncPeriod(t *testing.T) {
+	ipkg := &pkgingv1alpha1.PackageInstall{
+		ObjectMeta: metav1.ObjectMeta{
+			Name:      "app",
+			Namespace: "default",
+		},
+		Spec: pkgingv1alpha1.PackageInstallSpec{
+			SyncPeriod: &metav1.Duration{Duration: 100 * time.Second},
+		},
+	}
+
+	pkgVersion := datapkgingv1alpha1.Package{
+		Spec: datapkgingv1alpha1.PackageSpec{
+			RefName: "expec-pkg",
+			Version: "1.5.0",
+			Template: datapkgingv1alpha1.AppTemplateSpec{
+				Spec: &kcv1alpha1.AppSpec{},
+			},
+		},
+	}
+
+	app, err := packageinstall.NewApp(&kcv1alpha1.App{}, ipkg, pkgVersion, packageinstall.Opts{})
+	require.NoError(t, err)
+
+	expectedApp := &kcv1alpha1.App{
+		Spec: kcv1alpha1.AppSpec{
+			SyncPeriod: &metav1.Duration{Duration: 100 * time.Second},
+		},
+	}
+
+	// Not interesting in metadata in this test
+	app.ObjectMeta = metav1.ObjectMeta{}
+
+	require.Equal(t, expectedApp, app, "App does not match expected app")
+}
+
 func TestAppPackageDetailsAnnotations(t *testing.T) {
 	ipkg := &pkgingv1alpha1.PackageInstall{
 		ObjectMeta: metav1.ObjectMeta{