Skip to content

Commit 20a740a

Browse files
authored
Move resource ann creation after name checks (#1227)
Signed-off-by: Praveen Rewar <[email protected]>
1 parent a585895 commit 20a740a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

cli/pkg/kctrl/cmd/package/installed/create_or_update.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -204,8 +204,6 @@ func NewUpdateCmd(o *CreateOrUpdateOptions, flagsFactory cmdcore.FlagsFactory) *
204204
}
205205

206206
func (o *CreateOrUpdateOptions) RunCreate(args []string) error {
207-
o.createdAnnotations = NewCreatedResourceAnnotations(o.Name, o.NamespaceFlags.Name)
208-
209207
if o.pkgCmdTreeOpts.PositionalArgs {
210208
if len(args) > 0 {
211209
o.Name = args[0]
@@ -225,6 +223,8 @@ func (o *CreateOrUpdateOptions) RunCreate(args []string) error {
225223
return err
226224
}
227225

226+
o.createdAnnotations = NewCreatedResourceAnnotations(o.Name, o.NamespaceFlags.Name)
227+
228228
if o.DryRun {
229229
err := PackageInstalledDryRun{o}.PrintResources()
230230
if err != nil {

0 commit comments

Comments
 (0)