Skip to content

Commit 50138f1

Browse files
konraddysputkonraddysput
authored
Arabic language support (#70)
* Fixed invalid date in log manager when calendar is unsupported * Use single method to generate UTC timestamps + move it from extension code to static class to avoid unnecessary allocation * Fixed line endings * Updated native library * Removed debug logs from native library * Updated library version * Added invariant culture to rest of the code * native library update * Fixed issue in the readme file
1 parent f7e6a00 commit 50138f1

21 files changed

+206
-152
lines changed

‎CHANGELOG.md‎

Lines changed: 53 additions & 30 deletions
Large diffs are not rendered by default.

‎README.md‎

Lines changed: 63 additions & 48 deletions
Large diffs are not rendered by default.

‎Runtime/BacktraceClient.cs‎

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
using System;
99
using System.Collections;
1010
using System.Collections.Generic;
11+
using System.Globalization;
1112
using System.Threading;
1213
using UnityEngine;
1314

@@ -21,7 +22,7 @@ public class BacktraceClient : MonoBehaviour, IBacktraceClient
2122
{
2223
public BacktraceConfiguration Configuration;
2324

24-
public const string VERSION = "3.4.0-rc1";
25+
public const string VERSION = "3.4.0-rc2";
2526
public bool Enabled { get; private set; }
2627

2728
/// <summary>
@@ -676,7 +677,7 @@ record = Database.Add(data);
676677

677678
if (data.Deduplication != 0)
678679
{
679-
queryAttributes["_mod_duplicate"] = data.Deduplication.ToString();
680+
queryAttributes["_mod_duplicate"] = data.Deduplication.ToString(CultureInfo.InvariantCulture);
680681
}
681682

682683
StartCoroutine(BacktraceApi.Send(json, data.Attachments, queryAttributes, (BacktraceResult result) =>
@@ -916,7 +917,7 @@ private bool ShouldSendReport(Exception exception, List<string> attachmentPaths,
916917
}
917918

918919
//check rate limiting
919-
bool shouldProcess = _reportLimitWatcher.WatchReport(new DateTime().Timestamp());
920+
bool shouldProcess = _reportLimitWatcher.WatchReport(DateTimeHelper.Timestamp());
920921
if (shouldProcess)
921922
{
922923
// This condition checks if we should send exception from current thread
@@ -926,7 +927,7 @@ private bool ShouldSendReport(Exception exception, List<string> attachmentPaths,
926927
if (Thread.CurrentThread.ManagedThreadId != _current.ManagedThreadId)
927928
{
928929
var report = new BacktraceReport(exception, attributes, attachmentPaths);
929-
report.Attributes["exception.thread"] = Thread.CurrentThread.ManagedThreadId.ToString();
930+
report.Attributes["exception.thread"] = Thread.CurrentThread.ManagedThreadId.ToString(CultureInfo.InvariantCulture);
930931
BackgroundExceptions.Push(report);
931932
return false;
932933
}
@@ -951,7 +952,7 @@ private bool ShouldSendReport(string message, List<string> attachmentPaths, Dict
951952
}
952953

953954
//check rate limiting
954-
bool shouldProcess = _reportLimitWatcher.WatchReport(new DateTime().Timestamp());
955+
bool shouldProcess = _reportLimitWatcher.WatchReport(DateTimeHelper.Timestamp());
955956
if (shouldProcess)
956957
{
957958
// This condition checks if we should send exception from current thread
@@ -961,7 +962,7 @@ private bool ShouldSendReport(string message, List<string> attachmentPaths, Dict
961962
if (Thread.CurrentThread.ManagedThreadId != _current.ManagedThreadId)
962963
{
963964
var report = new BacktraceReport(message, attributes, attachmentPaths);
964-
report.Attributes["exception.thread"] = Thread.CurrentThread.ManagedThreadId.ToString();
965+
report.Attributes["exception.thread"] = Thread.CurrentThread.ManagedThreadId.ToString(CultureInfo.InvariantCulture);
965966
BackgroundExceptions.Push(report);
966967
return false;
967968
}
@@ -990,7 +991,7 @@ private bool ShouldSendReport(BacktraceReport report)
990991
return false;
991992
}
992993
//check rate limiting
993-
bool shouldProcess = _reportLimitWatcher.WatchReport(new DateTime().Timestamp());
994+
bool shouldProcess = _reportLimitWatcher.WatchReport(DateTimeHelper.Timestamp());
994995
if (shouldProcess)
995996
{
996997
// This condition checks if we should send exception from current thread
@@ -999,7 +1000,7 @@ private bool ShouldSendReport(BacktraceReport report)
9991000
// and let update method send data to Backtrace.
10001001
if (Thread.CurrentThread.ManagedThreadId != _current.ManagedThreadId)
10011002
{
1002-
report.Attributes["exception.thread"] = Thread.CurrentThread.ManagedThreadId.ToString();
1003+
report.Attributes["exception.thread"] = Thread.CurrentThread.ManagedThreadId.ToString(CultureInfo.InvariantCulture);
10031004
BackgroundExceptions.Push(report);
10041005
return false;
10051006
}

‎Runtime/BacktraceDatabase.cs‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
using Backtrace.Unity.Types;
77
using System;
88
using System.Collections.Generic;
9+
using System.Globalization;
910
using System.IO;
1011
using UnityEngine;
1112

@@ -372,7 +373,7 @@ private void FlushRecord(BacktraceDatabaseRecord record)
372373
return;
373374
}
374375

375-
queryAttributes["_mod_duplicate"] = record.Count.ToString();
376+
queryAttributes["_mod_duplicate"] = record.Count.ToString(CultureInfo.InvariantCulture);
376377

377378
StartCoroutine(
378379
BacktraceApi.Send(backtraceData, record.Attachments, queryAttributes, (BacktraceResult result) =>
@@ -403,7 +404,7 @@ private void SendData(BacktraceDatabaseRecord record)
403404
stopWatch.Stop();
404405
queryAttributes["performance.database.send"] = stopWatch.GetMicroseconds();
405406
}
406-
queryAttributes["_mod_duplicate"] = record.Count.ToString();
407+
queryAttributes["_mod_duplicate"] = record.Count.ToString(CultureInfo.InvariantCulture);
407408

408409
StartCoroutine(
409410
BacktraceApi.Send(backtraceData, record.Attachments, queryAttributes, (BacktraceResult sendResult) =>
@@ -418,7 +419,7 @@ private void SendData(BacktraceDatabaseRecord record)
418419
BacktraceDatabaseContext.IncrementBatchRetry();
419420
return;
420421
}
421-
bool shouldProcess = _reportLimitWatcher.WatchReport(new DateTime().Timestamp());
422+
bool shouldProcess = _reportLimitWatcher.WatchReport(DateTimeHelper.Timestamp());
422423
if (!shouldProcess)
423424
{
424425
return;

‎Runtime/Common/DateTimeHelper.cs‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
using System;
2+
using System.Collections.Generic;
3+
using System.Linq;
4+
using System.Text;
5+
using System.Threading.Tasks;
6+
7+
namespace Backtrace.Unity.Common
8+
{
9+
internal static class DateTimeHelper
10+
{
11+
public static int Timestamp()
12+
{
13+
return (int)(DateTime.UtcNow.Subtract(new DateTime(1970, 1, 1))).TotalSeconds;
14+
}
15+
}
16+
}

‎Runtime/Extensions/DateTimeExtensions.cs.meta‎ renamed to ‎Runtime/Common/DateTimeHelper.cs.meta‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎Runtime/Extensions/DateTimeExtensions.cs‎

Lines changed: 0 additions & 14 deletions
This file was deleted.

‎Runtime/Extensions/ThreadExtensions.cs‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
using System.Threading;
1+
using System.Globalization;
2+
using System.Threading;
23

34
namespace Backtrace.Unity.Extensions
45
{
@@ -18,7 +19,7 @@ public static string GenerateValidThreadName(this Thread thread)
1819
//in worst scenario thread name should be managedThreadId
1920
var threadName = thread.Name;
2021
threadName = string.IsNullOrEmpty(threadName)
21-
? thread.ManagedThreadId.ToString()
22+
? thread.ManagedThreadId.ToString(CultureInfo.InvariantCulture)
2223
: threadName;
2324

2425
return threadName;

‎Runtime/Json/BacktraceJObject.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public BacktraceJObject(Dictionary<string, string> source)
4747
/// <param name="value">value</param>
4848
public void Add(string key, bool value)
4949
{
50-
PrimitiveValues.Add(key, value.ToString().ToLower());
50+
PrimitiveValues.Add(key, value.ToString(CultureInfo.InvariantCulture).ToLower());
5151
}
5252

5353

@@ -100,7 +100,7 @@ public void Add(string key, string value)
100100
/// <param name="value">value</param>
101101
public void Add(string key, long value)
102102
{
103-
PrimitiveValues.Add(key, value.ToString());
103+
PrimitiveValues.Add(key, value.ToString(CultureInfo.InvariantCulture));
104104
}
105105

106106
/// <summary>

‎Runtime/Model/BacktraceReport.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public class BacktraceReport
3030
/// <summary>
3131
/// UTC timestamp in seconds
3232
/// </summary>
33-
public readonly long Timestamp = new DateTime().Timestamp();
33+
public readonly long Timestamp = DateTimeHelper.Timestamp();
3434

3535
/// <summary>
3636
/// Get information aboout report type. If value is true the BacktraceReport has an error information

0 commit comments

Comments
 (0)