* buckets/apr_buckets_refcount.c (apr_bucket_shared_copy):

notroj · notroj · commit ea4a9ea7c715 · 2019-08-29T10:39:59.000Z
Simplify code, allowing tail-call optimization, no functional change. git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1866064 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/buckets/apr_buckets_refcount.c b/buckets/apr_buckets_refcount.c
@@ -35,10 +35,9 @@ APR_DECLARE_NONSTD(apr_status_t) apr_bucket_shared_copy(apr_bucket *a,
 {
     apr_bucket_refcount *r = a->data;
 
-    apr_bucket_simple_copy(a, b);
     r->refcount++;
 
-    return APR_SUCCESS;
+    return apr_bucket_simple_copy(a, b);
 }
 
 APR_DECLARE(int) apr_bucket_shared_destroy(void *data)

Original file line number	Diff line number	Diff line change
`@@ -35,10 +35,9 @@ APR_DECLARE_NONSTD(apr_status_t) apr_bucket_shared_copy(apr_bucket *a,`
`35`	`35`	`{`
`36`	`36`	`apr_bucket_refcount *r = a->data;`
`37`	`37`
`38`		`- apr_bucket_simple_copy(a, b);`
`39`	`38`	`r->refcount++;`
`40`	`39`
`41`		`- return APR_SUCCESS;`
	`40`	`+ return apr_bucket_simple_copy(a, b);`
`42`	`41`	`}`
`43`	`42`
`44`	`43`	`APR_DECLARE(int) apr_bucket_shared_destroy(void *data)`