Skip to content

Commit 700166a

Browse files
committed
Arrange the windows testshm.
CreateFileMappingW returns APR_STATUS_IS_EEXIST and caused the test to fail on windows. git-svn-id: https://svn.apache.org/repos/asf/apr/apr/trunk@1928728 13f79535-47bb-0310-9956-ffa450edef68
1 parent 7142b62 commit 700166a

File tree

1 file changed

+13
-0
lines changed

1 file changed

+13
-0
lines changed

test/testshm.c

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,11 @@ static void test_named_remove(abts_case *tc, void *data)
219219
}
220220
ABTS_PTR_NOTNULL(tc, shm);
221221

222+
#ifdef WIN32
223+
rv = apr_shm_destroy(shm);
224+
#else
222225
rv = apr_shm_remove(SHARED_FILENAME, p);
226+
#endif
223227

224228
/* On platforms which acknowledge the removal of the shared resource,
225229
* ensure another of the same name may be created after removal;
@@ -237,8 +241,10 @@ static void test_named_remove(abts_case *tc, void *data)
237241
APR_ASSERT_SUCCESS(tc, "Error destroying shared memory block", rv);
238242
}
239243

244+
#ifndef WIN32
240245
rv = apr_shm_destroy(shm);
241246
APR_ASSERT_SUCCESS(tc, "Error destroying shared memory block", rv);
247+
#endif
242248

243249
/* Now ensure no named resource remains which we may attach to */
244250
rv = apr_shm_attach(&shm, SHARED_FILENAME, p);
@@ -259,7 +265,12 @@ static void test_named_delete(abts_case *tc, void *data)
259265
}
260266
ABTS_PTR_NOTNULL(tc, shm);
261267

268+
269+
#ifdef WIN32
270+
rv = apr_shm_destroy(shm);
271+
#else
262272
rv = apr_shm_delete(shm);
273+
#endif
263274

264275
/* On platforms which acknowledge the removal of the shared resource,
265276
* ensure another of the same name may be created after removal;
@@ -277,8 +288,10 @@ static void test_named_delete(abts_case *tc, void *data)
277288
APR_ASSERT_SUCCESS(tc, "Error destroying shared memory block", rv);
278289
}
279290

291+
#ifndef WIN32
280292
rv = apr_shm_destroy(shm);
281293
APR_ASSERT_SUCCESS(tc, "Error destroying shared memory block", rv);
294+
#endif
282295

283296
/* Now ensure no named resource remains which we may attach to */
284297
rv = apr_shm_attach(&shm, SHARED_FILENAME, p);

0 commit comments

Comments
 (0)