Batching no longer has concept of max size

This was confusing and the real performance inconsistency was caused
by not starting the timer before running the batch.

Author: andersmurphy

examples/billion_checkboxes_blob/src/app/main.clj

@@ -506,7 +506,7 @@
 
 (comment
   (do (-main) nil)
-  ;; (clojure.java.browse/browse-url "http://localhost:8080/")
+  ;; (clojure.java.browse/browse-url "https://localhost:3030/")
 
 
   ;; stop server
@@ -588,16 +588,17 @@
         (fn [_]
           (run!
             (fn [_]
-              (wrapped-router
-                {:headers
-                 {"accept-encoding" "br"
-                  "cookie"          "__Host-sid=5SNfeDa90PhXl0expOLFGdjtrpY; __Host-csrf=3UsG62ic9wLsg9EVQhGupw"
-                  "content-type"    "application/json"}
-                 :request-method :post
-                 :uri            handler-check
-                 :body           {:csrf     "3UsG62ic9wLsg9EVQhGupw"
-                                  :parentid "0"
-                                  :targetid (str (rand-int 200))}}))
+              (-> (wrapped-router
+                    {:headers
+                     {"accept-encoding" "br"
+                      "cookie"          "__Host-sid=5SNfeDa90PhXl0expOLFGdjtrpY; __Host-csrf=I3AAFrMG99lxoqwi87cSpn7unri5qYqJ-Vr9DLc4-s4"
+                      "content-type"    "application/json"}
+                     :request-method :post
+                     :uri            handler-check
+                     :body
+                     {:csrf     "I3AAFrMG99lxoqwi87cSpn7unri5qYqJ-Vr9DLc4-s4"
+                      :parentid "0"
+                      :targetid (str (rand-int 200))}})))
             ;; 10000r/s
             (range 10))
           (Thread/sleep 1))

src/hyperlith/impl/batch.clj

@@ -5,11 +5,9 @@
 
 (defn batch!
   "Wraps side-effecting function in a queue and batch mechanism. The
-  batch is run every X ms when not empty and/or if it reaches it's max
-  size. Function must take a vector of items. Supports back pressure."
-  [effect-fn & {:keys [run-every-ms max-size]
-                :or   {run-every-ms 100
-                       max-size     1000}}]
+  batch is run every X ms when not empty. Function must take a vector of items. Supports back pressure."
+  [effect-fn & {:keys [run-every-ms]
+                :or   {run-every-ms 100}}]
   (let [<in (a/chan 1000)] ;; potentially pass this channel in
     (util/thread
       (loop [<t    (a/timeout run-every-ms)
@@ -21,8 +19,7 @@
             (recur (a/timeout run-every-ms) batch)
 
             ;; Run batch
-            (or (= p <t)
-              (and (= p <in) (>= (count batch) max-size)))
+            (= p <t)
             (let [;; Timer is started before task to prevent task duration
                   ;; from affecting interval (unless it exceeds interval).
                   <new-t (a/timeout run-every-ms)]