handle sessionstorage disabled for saveReferrer

Author: djih

CHANGELOG.md

@@ -1,5 +1,7 @@
 ## Unreleased
 
+* Fix bug where saveReferrer throws exception if sessionStorage is disabled.
+
 ## 2.9.0 (January 15, 2016)
 
 * Add ability to clear all user properties.

amplitude-segment-snippet.min.js

@@ -1,6 +1,6 @@
-(function(e,t){var r=e.amplitude||{};var n=function(){this._q=[];return this};function s(e){
+(function(e,t){var r=e.amplitude||{};var n=function(){this._q=[];return this};function i(e){
 n.prototype[e]=function(){this._q.push([e].concat(Array.prototype.slice.call(arguments,0)));
-return this}}var i=["add","append","clearAll","set","setOnce","unset"];for(var o=0;o<i.length;o++){
-s(i[o])}r.Identify=n;r._q=[];function a(e){r[e]=function(){r._q.push([e].concat(Array.prototype.slice.call(arguments,0)));
+return this}}var o=["add","append","clearAll","set","setOnce","unset"];for(var s=0;s<o.length;s++){
+i(o[s])}r.Identify=n;r._q=[];function a(e){r[e]=function(){r._q.push([e].concat(Array.prototype.slice.call(arguments,0)));
 }}var c=["init","logEvent","logRevenue","setUserId","setUserProperties","setOptOut","setVersionName","setDomain","setDeviceId","setGlobalUserProperties","identify","clearUserProperties"];
 for(var l=0;l<c.length;l++){a(c[l])}e.amplitude=r})(window,document);

amplitude-snippet.min.js

@@ -1,9 +1,9 @@
 (function(e,t){var n=e.amplitude||{};var r=t.createElement("script");r.type="text/javascript";
 r.async=true;r.src="https://d24n15hnbwhuhn.cloudfront.net/libs/amplitude-2.9.0-min.gz.js";
 r.onload=function(){e.amplitude.runQueuedFunctions()};var s=t.getElementsByTagName("script")[0];
-s.parentNode.insertBefore(r,s);var i=function(){this._q=[];return this};function a(e){
+s.parentNode.insertBefore(r,s);var i=function(){this._q=[];return this};function o(e){
 i.prototype[e]=function(){this._q.push([e].concat(Array.prototype.slice.call(arguments,0)));
-return this}}var o=["add","append","clearAll","set","setOnce","unset"];for(var c=0;c<o.length;c++){
-a(o[c])}n.Identify=i;n._q=[];function u(e){n[e]=function(){n._q.push([e].concat(Array.prototype.slice.call(arguments,0)));
+return this}}var a=["add","append","clearAll","set","setOnce","unset"];for(var c=0;c<a.length;c++){
+o(a[c])}n.Identify=i;n._q=[];function u(e){n[e]=function(){n._q.push([e].concat(Array.prototype.slice.call(arguments,0)));
 }}var l=["init","logEvent","logRevenue","setUserId","setUserProperties","setOptOut","setVersionName","setDomain","setDeviceId","setGlobalUserProperties","identify","clearUserProperties"];
 for(var p=0;p<l.length;p++){u(l[p])}e.amplitude=n})(window,document);

amplitude.js

@@ -496,8 +496,16 @@ Amplitude.prototype._saveReferrer = function(referrer) {
   identify.setOnce('initial_referring_domain', referring_domain);
 
   // only save referrer if not already in session storage or if storage disabled
-  var hasSessionStorage = window.sessionStorage ? true : false;
-  if ((hasSessionStorage && !window.sessionStorage.getItem(LocalStorageKeys.REFERRER)) || !hasSessionStorage) {
+  var hasSessionStorage = false;
+  try {
+    if (window.sessionStorage) {
+      hasSessionStorage = true;
+    }
+  } catch (e) {
+    // log(e); // sessionStorage disabled
+  }
+
+  if (!hasSessionStorage || (hasSessionStorage && !window.sessionStorage.getItem(LocalStorageKeys.REFERRER))) {
     identify.set('referrer', referrer).set('referring_domain', referring_domain);
 
     if (hasSessionStorage) {

amplitude.min.js

@@ -390,8 +390,16 @@ Amplitude.prototype._saveReferrer = function(referrer) {
   identify.setOnce('initial_referring_domain', referring_domain);
 
   // only save referrer if not already in session storage or if storage disabled
-  var hasSessionStorage = window.sessionStorage ? true : false;
-  if ((hasSessionStorage && !window.sessionStorage.getItem(LocalStorageKeys.REFERRER)) || !hasSessionStorage) {
+  var hasSessionStorage = false;
+  try {
+    if (window.sessionStorage) {
+      hasSessionStorage = true;
+    }
+  } catch (e) {
+    // log(e); // sessionStorage disabled
+  }
+
+  if (!hasSessionStorage || (hasSessionStorage && !window.sessionStorage.getItem(LocalStorageKeys.REFERRER))) {
     identify.set('referrer', referrer).set('referring_domain', referring_domain);
 
     if (hasSessionStorage) {