Skip to content

Commit 80e85d7

Browse files
author
hubert
committed
perf: change createLoader parameters as object options
1 parent 2538fbb commit 80e85d7

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

packages/module-loader/src/createLoader.ts

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,22 @@ import type { ModuleLoader, GetResolver } from './types';
99

1010
/**
1111
* create module loader
12-
* @param resolver remote module resolver, default to umd resolver
12+
* @param options options
13+
* @param options.resolver remote module resolver, default to umd resolver
14+
* @param options.container container to append script, default is append to body in client side
1315
*/
1416
export function createLoader<Context = any>(
15-
resolver?: GetResolver<Context>,
16-
container?: string | ((proxy: Context) => Element),
17+
options: {
18+
resolver?: GetResolver<Context>;
19+
container?: string | ((proxy: Context) => Element);
20+
} = {},
1721
) {
22+
// Set global VueDemi
1823
if (window && !window.VueDemi) {
1924
window.VueDemi = VueDemi;
2025
}
2126

22-
const _resolver = resolver?.(container) ?? getUmdResolver(container as any);
27+
const _resolver = options.resolver?.(options.container) ?? getUmdResolver(options.container as any);
2328
const loader: ModuleLoader = VueDemi.markRaw({
2429
install(app) {
2530
// this allows calling registerSubModules() outside of a component setup after

0 commit comments

Comments
 (0)