Fix tests

Author: SubJunk

openapi.yaml

@@ -248,12 +248,6 @@ paths:
           schema:
             type: string
             example: 2003
-        - in: query
-          name: osdbHash
-          description: osdbHash of the media file
-          schema:
-            type: string
-            example: 0f0f4c9f3416e24f
         - in: query
           name: imdbID
           description: imdbID of the media file
@@ -272,12 +266,6 @@ paths:
           schema:
             type: string
             example: 1
-        - in: query
-          name: filebytesize
-          description: filebytesize of the media file
-          schema:
-            type: string
-            example: 2431697820
       responses:
         '200':
           description: Media metadata

src/controllers/media.ts

@@ -219,7 +219,7 @@ export const getVideoV2 = async(ctx: ParameterizedContext): Promise<MediaMetadat
   const { osdbHash, filebytesize }: DeprecatedUmsQueryParams = ctx.query;
   const { episode, season, year }: UmsQueryParams = ctx.query;
 
-  // this error will not be logged, the user just need to update to a new version of UMS
+  // this error will not be logged, the user just needs to update to a new version of UMS
   if (osdbHash && filebytesize) {
     throw new DeprecationError();
   }

test/e2e/media-video.spec.ts

@@ -21,8 +21,6 @@ let mongod: MongoMemoryServer;
 const MOVIE_INTERSTELLAR = {
   'imdbID': 'tt0816692',
   'title': 'Interstellar',
-  'osdbHash': '0f0f4c9f3416e24f',
-  'filebytesize': '2431697820',
   'plot': 'The adventures of a group of explorers who make use of a newly discovered wormhole to surpass the limitations on human space travel and conquer the vast distances involved in an interstellar voyage.'
 };
 
@@ -42,8 +40,6 @@ const EPISODE_LOST = {
 };
 
 const EPISODE_PRISONBREAK = {
-  'osdbHash': '35acba68a9dcfc8f',
-  'filebytesize': '271224190',
   'title': 'Prison Break',
   'episodeTitle': 'Behind the Eyes',
   'season': '5',
@@ -64,8 +60,6 @@ const EPISODE_DOCTORWHO = {
 
 const EPISODE_AVATAR = {
   'episodeTitle': 'The Boiling Rock (1) & The Boiling Rock (2)',
-  'osdbHash': 'de334f38f153fb6f',
-  'filebytesize': '4695739425',
   'season': '3',
   'episode': '14-15',
   'imdbID': 'tt1176477',
@@ -150,12 +144,12 @@ describe('get by all', () => {
     });
 
     test('should return a movie by all possible params, from source APIs then store', async() => {
-      let response = await axios.get(`${appUrl}/api/media/video/v2?osdbHash=${MOVIE_INTERSTELLAR.osdbHash}&filebytesize=${MOVIE_INTERSTELLAR.filebytesize}&title=${MOVIE_INTERSTELLAR.title}&imdbID=${MOVIE_INTERSTELLAR.imdbID}`) as UmsApiMediaAxiosResponse;
+      let response = await axios.get(`${appUrl}/api/media/video/v2?title=${MOVIE_INTERSTELLAR.title}&imdbID=${MOVIE_INTERSTELLAR.imdbID}`) as UmsApiMediaAxiosResponse;
       expect(response.data.title).toEqual(MOVIE_INTERSTELLAR.title);
       expect(response.data.type).toEqual('movie');
 
       // subsequent calls should return MongoDB result rather than calling external apis
-      response = await axios.get(`${appUrl}/api/media/video/v2?osdbHash=${MOVIE_INTERSTELLAR.osdbHash}&filebytesize=${MOVIE_INTERSTELLAR.filebytesize}&title=${MOVIE_INTERSTELLAR.title}&imdbID=${MOVIE_INTERSTELLAR.imdbID}`);
+      response = await axios.get(`${appUrl}/api/media/video/v2?title=${MOVIE_INTERSTELLAR.title}&imdbID=${MOVIE_INTERSTELLAR.imdbID}`);
       expect(response.data.title).toEqual(MOVIE_INTERSTELLAR.title);
       expect(response.data.type).toEqual('movie');
     });
@@ -222,9 +216,7 @@ describe('get by all', () => {
 
     test('should return an episode by all possible params, from source APIs then store', async() => {
       const url = `${appUrl}/api/media/video/v2?`+
-        `osdbHash=${EPISODE_PRISONBREAK.osdbHash}`+
-        `&filebytesize=${EPISODE_PRISONBREAK.filebytesize}`+
-        `&title=${EPISODE_PRISONBREAK.title}`+
+        `title=${EPISODE_PRISONBREAK.title}`+
         `&season=${EPISODE_PRISONBREAK.season}`+
         `&episode=${EPISODE_PRISONBREAK.episode}`+
         `&year=${EPISODE_PRISONBREAK.year}`;
@@ -262,9 +254,7 @@ describe('get by all', () => {
 
     test('should return two episodes when passed all possible params, from source APIs then store', async() => {
       const url = `${appUrl}/api/media/video/v2?`+
-        `osdbHash=${EPISODE_AVATAR.osdbHash}`+
-        `&filebytesize=${EPISODE_AVATAR.filebytesize}`+
-        `&title=${EPISODE_AVATAR.title}`+
+        `title=${EPISODE_AVATAR.title}`+
         `&season=${EPISODE_AVATAR.season}`+
         `&episode=${EPISODE_AVATAR.episode}`+
         `&year=${EPISODE_AVATAR.year}`;