Merge pull request #2 from ssp/master

small changes

Author: tiennou

Classes/Util/GitXCommitCopier.m

@@ -55,7 +55,7 @@ + (NSString *) toPatch:(NSArray<PBGitCommit *> *)commits {
 + (NSArray<NSString *> *) transformCommits:(NSArray<PBGitCommit *> *)commits with:(NSString *(^)(PBGitCommit *  commit))transformer {
 
 	NSMutableArray *strings = [NSMutableArray arrayWithCapacity:commits.count];
-	[commits enumerateObjectsUsingBlock:^(PBGitCommit * _Nonnull commit, NSUInteger idx, BOOL * _Nonnull stop) {
+	[commits enumerateObjectsWithOptions:NSEnumerationReverse usingBlock:^(PBGitCommit * _Nonnull commit, NSUInteger idx, BOOL * _Nonnull stop) {
 		[strings addObject:transformer(commit)];
 	}];
 

Classes/git/PBGitIndex.m

@@ -389,7 +389,6 @@ - (BOOL)performStageOrUnstage:(BOOL)stage withFiles:(NSArray *)files
 	if (loopTo > filesCount)
 		loopTo = filesCount;
 	int loopCount = 0;
-	int i = 0;
 
 	// Staging
 	while (loopCount < filesCount) {
@@ -399,7 +398,7 @@ - (BOOL)performStageOrUnstage:(BOOL)stage withFiles:(NSArray *)files
 		// "git add -- <files>
 		NSMutableString *input = [NSMutableString string];
 
-		for (i = loopFrom; i < loopTo; i++) {
+		for (int i = loopFrom; i < loopTo; i++) {
 			loopCount++;
 
 			PBChangedFile *file = [files objectAtIndex:i];
@@ -418,7 +417,6 @@ - (BOOL)performStageOrUnstage:(BOOL)stage withFiles:(NSArray *)files
 			}
 		}
 
-
 		int ret = 1;
 		if (stage) {
 			[self.repository outputForArguments:[NSArray arrayWithObjects:@"update-index", @"--add", @"--remove", @"-z", @"--stdin", nil]
@@ -435,16 +433,10 @@ - (BOOL)performStageOrUnstage:(BOOL)stage withFiles:(NSArray *)files
 			return NO;
 		}
 
-		for (i = loopFrom; i < loopTo; i++) {
+		for (int i = loopFrom; i < loopTo; i++) {
 			PBChangedFile *file = [files objectAtIndex:i];
-
-			if (stage) {
-				file.hasUnstagedChanges = NO;
-				file.hasStagedChanges = YES;
-			} else {
-				file.hasUnstagedChanges = YES;
-				file.hasStagedChanges = NO;
-			}
+			file.hasStagedChanges = stage;
+			file.hasUnstagedChanges = !stage;
 		}
 
 		// Prepare next iteration
@@ -453,6 +445,9 @@ - (BOOL)performStageOrUnstage:(BOOL)stage withFiles:(NSArray *)files
 		if (loopTo > filesCount)
 			loopTo = filesCount;
 	}
+	
+	[self postIndexChange];
+	
 	return YES;
 }
 

English.lproj/MainMenu.xib

@@ -169,16 +169,16 @@
                                     <action selector="copy:" target="-1" id="181"/>
                                 </connections>
                             </menuItem>
-                            <menuItem title="Copy SHA" alternate="YES" keyEquivalent="c" id="964">
+                            <menuItem title="Copy short SHA" alternate="YES" keyEquivalent="c" id="Q6u-9U-Mue">
                                 <modifierMask key="keyEquivalentModifierMask" option="YES" command="YES"/>
                                 <connections>
-                                    <action selector="copySHA:" target="-1" id="966"/>
+                                    <action selector="copyShortName:" target="-1" id="feT-ND-ZxS"/>
                                 </connections>
                             </menuItem>
-                            <menuItem title="Copy short SHA" alternate="YES" keyEquivalent="C" id="Q6u-9U-Mue">
+                            <menuItem title="Copy full SHA" alternate="YES" keyEquivalent="C" id="964">
                                 <modifierMask key="keyEquivalentModifierMask" option="YES" command="YES"/>
                                 <connections>
-                                    <action selector="copyShortName:" target="-1" id="feT-ND-ZxS"/>
+                                    <action selector="copySHA:" target="-1" id="966"/>
                                 </connections>
                             </menuItem>
                             <menuItem title="Copy Patch" alternate="YES" keyEquivalent="c" id="ZiX-Nf-qba">