Cast to int in HeaderSelector::getNextWeight()

Author: wbohlken

modules/openapi-generator/src/main/resources/php-nextgen/HeaderSelector.mustache

@@ -186,12 +186,12 @@ class HeaderSelector
 
     /**
      * @param string $header
-     * @param int    $weight
+     * @param float  $weight
      * @return string
      */
-    private function buildAcceptHeader(string $header, int $weight): string
+    private function buildAcceptHeader(string $header, float $weight): string
     {
-        if($weight === 1000) {
+        if ($weight === 1000.0) {
             return $header;
         }
 
@@ -216,11 +216,11 @@ class HeaderSelector
      * if there is a maximum of 28 "Accept" headers. If we have more than that (which is extremely unlikely), then we fall back to a 1-by-1
      * decrement rule, which will result in quality codes like "q=0.999", "q=0.998" etc.
      *
-     * @param int  $currentWeight varying from 1 to 1000 (will be divided by 1000 to build the quality value)
-     * @param bool $hasMoreThan28Headers
-     * @return int
+     * @param float $currentWeight varying from 1 to 1000 (will be divided by 1000 to build the quality value)
+     * @param bool  $hasMoreThan28Headers
+     * @return float
      */
-    public function getNextWeight(int $currentWeight, bool $hasMoreThan28Headers): int
+    public function getNextWeight(float $currentWeight, bool $hasMoreThan28Headers): float
     {
         if ($currentWeight <= 1) {
             return 1;
@@ -230,6 +230,6 @@ class HeaderSelector
             return $currentWeight - 1;
         }
 
-        return $currentWeight - 10 ** floor( log10($currentWeight - 1) );
+        return $currentWeight - 10 ** floor(log10($currentWeight - 1));
     }
 }

samples/client/echo_api/php-nextgen-streaming/src/HeaderSelector.php

@@ -166,11 +166,11 @@ private function getHeaderAndWeight(string $header): array
 
     /**
      * @param array[] $headers
-     * @param float   $currentWeight
+     * @param int     $currentWeight
      * @param bool    $hasMoreThan28Headers
      * @return string[] array of adjusted "Accept" headers
      */
-    private function adjustWeight(array $headers, float &$currentWeight, bool $hasMoreThan28Headers): array
+    private function adjustWeight(array $headers, int &$currentWeight, bool $hasMoreThan28Headers): array
     {
         usort($headers, function (array $a, array $b) {
             return $b['weight'] - $a['weight'];
@@ -239,6 +239,6 @@ public function getNextWeight(int $currentWeight, bool $hasMoreThan28Headers): i
             return $currentWeight - 1;
         }
 
-        return $currentWeight - 10 ** floor( log10($currentWeight - 1) );
+        return (int) ($currentWeight - 10 ** floor( log10($currentWeight - 1) ));
     }
 }

samples/client/echo_api/php-nextgen/src/HeaderSelector.php

@@ -166,11 +166,11 @@ private function getHeaderAndWeight(string $header): array
 
     /**
      * @param array[] $headers
-     * @param float   $currentWeight
+     * @param int     $currentWeight
      * @param bool    $hasMoreThan28Headers
      * @return string[] array of adjusted "Accept" headers
      */
-    private function adjustWeight(array $headers, float &$currentWeight, bool $hasMoreThan28Headers): array
+    private function adjustWeight(array $headers, int &$currentWeight, bool $hasMoreThan28Headers): array
     {
         usort($headers, function (array $a, array $b) {
             return $b['weight'] - $a['weight'];
@@ -239,6 +239,6 @@ public function getNextWeight(int $currentWeight, bool $hasMoreThan28Headers): i
             return $currentWeight - 1;
         }
 
-        return $currentWeight - 10 ** floor( log10($currentWeight - 1) );
+        return (int) ($currentWeight - 10 ** floor( log10($currentWeight - 1) ));
     }
 }

samples/client/petstore/php-nextgen/OpenAPIClient-php/src/HeaderSelector.php

@@ -165,11 +165,11 @@ private function getHeaderAndWeight(string $header): array
 
     /**
      * @param array[] $headers
-     * @param float   $currentWeight
+     * @param int     $currentWeight
      * @param bool    $hasMoreThan28Headers
      * @return string[] array of adjusted "Accept" headers
      */
-    private function adjustWeight(array $headers, float &$currentWeight, bool $hasMoreThan28Headers): array
+    private function adjustWeight(array $headers, int &$currentWeight, bool $hasMoreThan28Headers): array
     {
         usort($headers, function (array $a, array $b) {
             return $b['weight'] - $a['weight'];
@@ -238,6 +238,6 @@ public function getNextWeight(int $currentWeight, bool $hasMoreThan28Headers): i
             return $currentWeight - 1;
         }
 
-        return $currentWeight - 10 ** floor( log10($currentWeight - 1) );
+        return (int) ($currentWeight - 10 ** floor( log10($currentWeight - 1) ));
     }
 }