Don't test Optional<?> for null in DeferredLogger

joschi · joschi · commit 406f3ec009b3 · 2021-12-05T10:10:33.000+01:00
https://sonarcloud.io/organizations/openapitools/rules?open=java%3AS2789&rule_key=java%3AS2789
diff --git a/core/src/main/java/org/openapitools/openapidiff/core/model/deferred/DeferredLogger.java b/core/src/main/java/org/openapitools/openapidiff/core/model/deferred/DeferredLogger.java
@@ -19,11 +19,7 @@ public String toString() {
   }
 
   public static String optionalToString(Optional<?> value) {
-    if (value == null) {
-      return "null";
-    } else {
-      return value.map((v) -> "Optional[" + valueToString(v) + "]").orElse("Optional[empty]");
-    }
+    return value.map((v) -> "Optional[" + valueToString(v) + "]").orElse("Optional[empty]");
   }
 
   public static String changedToString(Changed value) {

Original file line number	Diff line number	Diff line change
`@@ -19,11 +19,7 @@ public String toString() {`
`19`	`19`	`}`
`20`	`20`
`21`	`21`	`public static String optionalToString(Optional<?> value) {`
`22`		`- if (value == null) {`
`23`		`- return "null";`
`24`		`- } else {`
`25`		`- return value.map((v) -> "Optional[" + valueToString(v) + "]").orElse("Optional[empty]");`
`26`		`- }`
	`22`	`+ return value.map((v) -> "Optional[" + valueToString(v) + "]").orElse("Optional[empty]");`
`27`	`23`	`}`
`28`	`24`
`29`	`25`	`public static String changedToString(Changed value) {`