Remove should_keep_forever from retention_policy in multiple Terraform files

mcasperson · mcasperson · commit 79037d6368c7 · 2025-10-27T09:35:33.000+10:00
diff --git a/argocd_dashboard/projects/argo_cd_template/octopus/argocd_project_template_project.tf b/argocd_dashboard/projects/argo_cd_template/octopus/argocd_project_template_project.tf
@@ -80,7 +80,6 @@ resource "octopusdeploy_runbook" "runbook_create_project" {
 
   retention_policy {
     quantity_to_keep    = 100
-    should_keep_forever = false
   }
 
   connectivity_policy {
diff --git a/management_instance/projects/azure_space_initialization/octopus/terraform.tf b/management_instance/projects/azure_space_initialization/octopus/terraform.tf
@@ -104,7 +104,6 @@ resource "octopusdeploy_runbook" "runbook_backend_service_deploy_project" {
 
   retention_policy {
     quantity_to_keep    = 100
-    should_keep_forever = false
   }
 
   connectivity_policy {
diff --git a/management_instance/projects/azure_web_app_cac/octopus/terraform.tf b/management_instance/projects/azure_web_app_cac/octopus/terraform.tf
@@ -376,7 +376,6 @@ resource "octopusdeploy_runbook" "runbook_delete_web_app" {
 
   retention_policy {
     quantity_to_keep    = 100
-    should_keep_forever = false
   }
 
   connectivity_policy {
@@ -445,7 +444,6 @@ resource "octopusdeploy_runbook" "runbook_get_web_app_logs" {
 
   retention_policy {
     quantity_to_keep    = 100
-    should_keep_forever = false
   }
 
   connectivity_policy {
@@ -524,7 +522,6 @@ resource "octopusdeploy_runbook" "runbook_restart_web_app" {
 
   retention_policy {
     quantity_to_keep    = 100
-    should_keep_forever = false
   }
 
   connectivity_policy {
@@ -599,7 +596,6 @@ resource "octopusdeploy_runbook" "create_incident_channel" {
 
   retention_policy {
     quantity_to_keep    = 100
-    should_keep_forever = false
   }
 
   connectivity_policy {
diff --git a/management_instance/projects/k8s_microservice/octopus/terraform.tf b/management_instance/projects/k8s_microservice/octopus/terraform.tf
@@ -650,7 +650,6 @@ resource "octopusdeploy_runbook" "runbook_k8s_get_service" {
 
   retention_policy {
     quantity_to_keep    = 100
-    should_keep_forever = false
   }
 
   connectivity_policy {
@@ -717,7 +716,6 @@ resource "octopusdeploy_runbook" "runbook_k8s_get_pod" {
 
   retention_policy {
     quantity_to_keep    = 100
-    should_keep_forever = false
   }
 
   connectivity_policy {
@@ -784,7 +782,6 @@ resource "octopusdeploy_runbook" "runbook_k8s_describe_pod" {
 
   retention_policy {
     quantity_to_keep    = 100
-    should_keep_forever = false
   }
 
   connectivity_policy {
@@ -851,7 +848,6 @@ resource "octopusdeploy_runbook" "runbook_k8s_pod_logs" {
 
   retention_policy {
     quantity_to_keep    = 100
-    should_keep_forever = false
   }
 
   connectivity_policy {
@@ -873,7 +869,6 @@ resource "octopusdeploy_runbook" "create_incident_channel" {
 
   retention_policy {
     quantity_to_keep    = 100
-    should_keep_forever = false
   }
 
   connectivity_policy {
@@ -937,7 +932,6 @@ resource "octopusdeploy_runbook" "runbook_k8s_microservice_template_scan_pod_log
 
   retention_policy {
     quantity_to_keep    = 100
-    should_keep_forever = false
   }
 
   connectivity_policy {
diff --git a/management_instance/projects/k8s_space_initialization/octopus/terraform.tf b/management_instance/projects/k8s_space_initialization/octopus/terraform.tf
@@ -104,7 +104,6 @@ resource "octopusdeploy_runbook" "runbook_backend_service_deploy_project" {
 
   retention_policy {
     quantity_to_keep    = 100
-    should_keep_forever = false
   }
 
   connectivity_policy {
diff --git a/management_instance/projects/pr_checks/octopus/terraform.tf b/management_instance/projects/pr_checks/octopus/terraform.tf
@@ -85,7 +85,6 @@ resource "octopusdeploy_runbook" "runbook" {
 
   retention_policy {
     quantity_to_keep    = 100
-    should_keep_forever = false
   }
 
   connectivity_policy {
diff --git a/management_instance/runbooks/conflict/octopus/terraform.tf b/management_instance/runbooks/conflict/octopus/terraform.tf
@@ -75,7 +75,6 @@ resource "octopusdeploy_runbook" "runbook_merge_git" {
 
   retention_policy {
     quantity_to_keep    = 100
-    should_keep_forever = false
   }
 
   connectivity_policy {
diff --git a/management_instance/runbooks/fork/octopus/terraform.tf b/management_instance/runbooks/fork/octopus/terraform.tf
@@ -120,7 +120,6 @@ resource "octopusdeploy_runbook" "runbook_backend_service_deploy_project" {
 
   retention_policy {
     quantity_to_keep    = 100
-    should_keep_forever = false
   }
 
   connectivity_policy {
@@ -185,7 +184,6 @@ resource "octopusdeploy_runbook" "runbook_backend_service_serialize_project" {
 
   retention_policy {
     quantity_to_keep    = 100
-    should_keep_forever = false
   }
 
   connectivity_policy {
diff --git a/management_instance/runbooks/list/octopus/terraform.tf b/management_instance/runbooks/list/octopus/terraform.tf
@@ -75,7 +75,6 @@ resource "octopusdeploy_runbook" "runbook_merge_git" {
 
   retention_policy {
     quantity_to_keep    = 100
-    should_keep_forever = false
   }
 
   connectivity_policy {
diff --git a/management_instance/runbooks/merge/octopus/terraform.tf b/management_instance/runbooks/merge/octopus/terraform.tf
@@ -78,7 +78,6 @@ resource "octopusdeploy_runbook" "runbook_merge_git" {
 
   retention_policy {
     quantity_to_keep    = 100
-    should_keep_forever = false
   }
 
   connectivity_policy {
@@ -138,7 +137,6 @@ resource "octopusdeploy_runbook" "runbook_merge_all_git" {
 
   retention_policy {
     quantity_to_keep    = 100
-    should_keep_forever = false
   }
 
   connectivity_policy {
diff --git a/management_instance/runbooks/serialize_and_deploy/octopus/terraform.tf b/management_instance/runbooks/serialize_and_deploy/octopus/terraform.tf
@@ -102,7 +102,6 @@ resource "octopusdeploy_runbook" "runbook_backend_service_deploy_project" {
 
   retention_policy {
     quantity_to_keep    = 100
-    should_keep_forever = false
   }
 
   connectivity_policy {

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,6 @@ resource "octopusdeploy_runbook" "runbook_create_project" {`
`80`	`80`
`81`	`81`	`retention_policy {`
`82`	`82`	`quantity_to_keep = 100`
`83`		`- should_keep_forever = false`
`84`	`83`	`}`
`85`	`84`
`86`	`85`	`connectivity_policy {`
Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,6 @@ resource "octopusdeploy_runbook" "runbook_backend_service_deploy_project" {`
`104`	`104`
`105`	`105`	`retention_policy {`
`106`	`106`	`quantity_to_keep = 100`
`107`		`- should_keep_forever = false`
`108`	`107`	`}`
`109`	`108`
`110`	`109`	`connectivity_policy {`
Original file line number	Diff line number	Diff line change
`@@ -376,7 +376,6 @@ resource "octopusdeploy_runbook" "runbook_delete_web_app" {`
`376`	`376`
`377`	`377`	`retention_policy {`
`378`	`378`	`quantity_to_keep = 100`
`379`		`- should_keep_forever = false`
`380`	`379`	`}`
`381`	`380`
`382`	`381`	`connectivity_policy {`
`@@ -445,7 +444,6 @@ resource "octopusdeploy_runbook" "runbook_get_web_app_logs" {`
`445`	`444`
`446`	`445`	`retention_policy {`
`447`	`446`	`quantity_to_keep = 100`
`448`		`- should_keep_forever = false`
`449`	`447`	`}`
`450`	`448`
`451`	`449`	`connectivity_policy {`
`@@ -524,7 +522,6 @@ resource "octopusdeploy_runbook" "runbook_restart_web_app" {`
`524`	`522`
`525`	`523`	`retention_policy {`
`526`	`524`	`quantity_to_keep = 100`
`527`		`- should_keep_forever = false`
`528`	`525`	`}`
`529`	`526`
`530`	`527`	`connectivity_policy {`
`@@ -599,7 +596,6 @@ resource "octopusdeploy_runbook" "create_incident_channel" {`
`599`	`596`
`600`	`597`	`retention_policy {`
`601`	`598`	`quantity_to_keep = 100`
`602`		`- should_keep_forever = false`
`603`	`599`	`}`
`604`	`600`
`605`	`601`	`connectivity_policy {`
Original file line number	Diff line number	Diff line change
`@@ -650,7 +650,6 @@ resource "octopusdeploy_runbook" "runbook_k8s_get_service" {`
`650`	`650`
`651`	`651`	`retention_policy {`
`652`	`652`	`quantity_to_keep = 100`
`653`		`- should_keep_forever = false`
`654`	`653`	`}`
`655`	`654`
`656`	`655`	`connectivity_policy {`
`@@ -717,7 +716,6 @@ resource "octopusdeploy_runbook" "runbook_k8s_get_pod" {`
`717`	`716`
`718`	`717`	`retention_policy {`
`719`	`718`	`quantity_to_keep = 100`
`720`		`- should_keep_forever = false`
`721`	`719`	`}`
`722`	`720`
`723`	`721`	`connectivity_policy {`
`@@ -784,7 +782,6 @@ resource "octopusdeploy_runbook" "runbook_k8s_describe_pod" {`
`784`	`782`
`785`	`783`	`retention_policy {`
`786`	`784`	`quantity_to_keep = 100`
`787`		`- should_keep_forever = false`
`788`	`785`	`}`
`789`	`786`
`790`	`787`	`connectivity_policy {`
`@@ -851,7 +848,6 @@ resource "octopusdeploy_runbook" "runbook_k8s_pod_logs" {`
`851`	`848`
`852`	`849`	`retention_policy {`
`853`	`850`	`quantity_to_keep = 100`
`854`		`- should_keep_forever = false`
`855`	`851`	`}`
`856`	`852`
`857`	`853`	`connectivity_policy {`
`@@ -873,7 +869,6 @@ resource "octopusdeploy_runbook" "create_incident_channel" {`
`873`	`869`
`874`	`870`	`retention_policy {`
`875`	`871`	`quantity_to_keep = 100`
`876`		`- should_keep_forever = false`
`877`	`872`	`}`
`878`	`873`
`879`	`874`	`connectivity_policy {`
`@@ -937,7 +932,6 @@ resource "octopusdeploy_runbook" "runbook_k8s_microservice_template_scan_pod_log`
`937`	`932`
`938`	`933`	`retention_policy {`
`939`	`934`	`quantity_to_keep = 100`
`940`		`- should_keep_forever = false`
`941`	`935`	`}`
`942`	`936`
`943`	`937`	`connectivity_policy {`
Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,6 @@ resource "octopusdeploy_runbook" "runbook" {`
`85`	`85`
`86`	`86`	`retention_policy {`
`87`	`87`	`quantity_to_keep = 100`
`88`		`- should_keep_forever = false`
`89`	`88`	`}`
`90`	`89`
`91`	`90`	`connectivity_policy {`
Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,6 @@ resource "octopusdeploy_runbook" "runbook_merge_git" {`
`75`	`75`
`76`	`76`	`retention_policy {`
`77`	`77`	`quantity_to_keep = 100`
`78`		`- should_keep_forever = false`
`79`	`78`	`}`
`80`	`79`
`81`	`80`	`connectivity_policy {`
Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,6 @@ resource "octopusdeploy_runbook" "runbook_backend_service_deploy_project" {`
`120`	`120`
`121`	`121`	`retention_policy {`
`122`	`122`	`quantity_to_keep = 100`
`123`		`- should_keep_forever = false`
`124`	`123`	`}`
`125`	`124`
`126`	`125`	`connectivity_policy {`
`@@ -185,7 +184,6 @@ resource "octopusdeploy_runbook" "runbook_backend_service_serialize_project" {`
`185`	`184`
`186`	`185`	`retention_policy {`
`187`	`186`	`quantity_to_keep = 100`
`188`		`- should_keep_forever = false`
`189`	`187`	`}`
`190`	`188`
`191`	`189`	`connectivity_policy {`
Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,6 @@ resource "octopusdeploy_runbook" "runbook_merge_git" {`
`78`	`78`
`79`	`79`	`retention_policy {`
`80`	`80`	`quantity_to_keep = 100`
`81`		`- should_keep_forever = false`
`82`	`81`	`}`
`83`	`82`
`84`	`83`	`connectivity_policy {`
`@@ -138,7 +137,6 @@ resource "octopusdeploy_runbook" "runbook_merge_all_git" {`
`138`	`137`
`139`	`138`	`retention_policy {`
`140`	`139`	`quantity_to_keep = 100`
`141`		`- should_keep_forever = false`
`142`	`140`	`}`
`143`	`141`
`144`	`142`	`connectivity_policy {`