Commit 11c5926
committed
Fix clean_term (including double quotes)
Why are these changes being introduced:
* Double quotes were breaking searches
Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/USE-237
How does this address that need:
* Updates our `clean_term` method in the Primo model to use
`URI.encode_www_form_component` instead of our bespoke logic
Document any side effects to this change:
* I believe this fixes some unreported issues with our `clean_term`
method. We replaced a few characters with `+` and did some very odd
things with `++` (likley to "help" with searching for `c++`) that
seem to have been making things worse not better. Using the form
encoding method seems to handle those types of searches much more in
line with how Primo UI works.1 parent dc5ffc3 commit 11c5926
2 files changed
+24
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
100 | | - | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
101 | 106 | | |
102 | | - | |
| 107 | + | |
103 | 108 | | |
104 | 109 | | |
105 | 110 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
| 62 | + | |
| 63 | + | |
62 | 64 | | |
63 | | - | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
64 | 80 | | |
65 | 81 | | |
66 | 82 | | |
| |||
0 commit comments