Merge pull request #895 from ExtensionEngine/fix/root-level-activity-delete

underscope · web-flow · commit 0e3e74ef0e82 · 2021-06-18T09:19:22.000+02:00
Return if there are no filepaths
diff --git a/server/shared/storage/providers/amazon.js b/server/shared/storage/providers/amazon.js
@@ -98,6 +98,7 @@ class Amazon {
   // API docs: https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/S3.html#deleteObjects-property
   deleteFiles(keys, options = {}) {
     const objects = keys.map(key => ({ Key: key }));
+    if (!keys.length) return Promise.resolve();
     const params = Object.assign(options, { Bucket: this.bucket, Delete: { Objects: objects } });
     return this.client.deleteObjects(params).promise();
   }

Original file line number	Diff line number	Diff line change
`@@ -98,6 +98,7 @@ class Amazon {`
`98`	`98`	`// API docs: https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/S3.html#deleteObjects-property`
`99`	`99`	`deleteFiles(keys, options = {}) {`
`100`	`100`	`const objects = keys.map(key => ({ Key: key }));`
	`101`	`+ if (!keys.length) return Promise.resolve();`
`101`	`102`	`const params = Object.assign(options, { Bucket: this.bucket, Delete: { Objects: objects } });`
`102`	`103`	`return this.client.deleteObjects(params).promise();`
`103`	`104`	`}`