fix import

Author: QuentinGab

src/Services/Exporter/CsvExporterService.php

@@ -74,7 +74,9 @@ public function import(string $path): array
                     $translationsByLocale[$locale] = [];
                 }
 
-                $translationsByLocale[$locale][$key] = $value;
+                if ($value) {
+                    $translationsByLocale[$locale][$key] = $value;
+                }
 
             }
 

tests/Feature/ExportTest.php

@@ -23,6 +23,12 @@
     Storage::disk('csv')->assertExists($file);
 });
 
+/**
+ * Warning
+ *
+ * Conflicts might occur when keys are different between locales
+ * If `en` define `auth.message.title` and `fr` define `auth.message`, `auth.message.title` might be overriden
+ */
 it('imports all locales and keys from a csv file', function () {
     $translator = new Translator(
         driver: $this->getPhpDriver(),
@@ -35,10 +41,12 @@
         'en' => [
             'messages.hello' => 'Hello',
             'messages.add' => 'Add',
+            'messages.nested.foo' => 'Foo',
         ],
         'fr' => [
             'messages.hello' => 'Bonjour',
             'messages.add' => 'Ajouter',
+            'messages.nested' => 'Nested',
         ],
     ]);
 

tests/files/import.csv

@@ -1,3 +1,5 @@
 key,en,fr
 messages.hello,Hello,Bonjour
 messages.add,Add,Ajouter
+messages.nested.foo,Foo,
+messages.nested,,Nested