BUG: Rework API for DataMap and DeepCopy in DataObject.

We need to be able to report errors back up the call tree if possible.

Signed-off-by: Michael Jackson <[email protected]>

Author: imikejackson

src/simplnx/DataStructure/AttributeMatrix.cpp

@@ -96,7 +96,10 @@ bool AttributeMatrix::canInsert(const DataObject* obj) const
 
   const usize totalTuples = std::accumulate(m_TupleShape.cbegin(), m_TupleShape.cend(), static_cast<usize>(1), std::multiplies<>());
   const usize incomingTupleCount = std::accumulate(arrayTupleShape.cbegin(), arrayTupleShape.cend(), static_cast<usize>(1), std::multiplies<>());
-
+  if(totalTuples != incomingTupleCount)
+  {
+    std::cout << "AttributeMatrix: CanInsert() Failed with object " << obj->getName() << ". totalTuples=" << totalTuples << "  incomingTupleCount=" << incomingTupleCount << "\n";
+  }
   return (totalTuples == incomingTupleCount);
 }
 

src/simplnx/DataStructure/DataMap.cpp

@@ -30,6 +30,10 @@ DataMap DataMap::deepCopy(const DataPath& parentCopyPath) const
   {
     const auto& dataObj = m_Map.at(key);
     const auto copy = dataObj->deepCopy(parentCopyPath.createChildPath(dataObj->getName()));
+    if(copy == nullptr)
+    {
+      throw std::runtime_error(fmt::format("A deep copy request for parent '{}' failed on child object '{}' ", parentCopyPath.toString(), dataObj->getName()));
+    }
     dataMap.m_Map[key] = copy;
   }
   return dataMap;