fix: make FinalScriptsFunc backwards compatible by moving isTapscript param to the end

Author: motorina0

src/psbt.js

@@ -294,9 +294,9 @@ class Psbt {
       input,
       script,
       isSegwit,
-      isTapscript,
       isP2SH,
       isP2WSH,
+      isTapscript,
       this.__CACHE.__EC_LIB,
     );
     if (finalScriptSig) this.data.updateInput(inputIndex, { finalScriptSig });
@@ -932,9 +932,9 @@ function getFinalScripts(
   input,
   script,
   isSegwit,
-  isTapscript,
   isP2SH,
   isP2WSH,
+  isTapscript = false,
   eccLib,
 ) {
   const scriptType = classifyScript(script, eccLib);

test/integration/csv.spec.ts

@@ -439,7 +439,6 @@ function csvGetFinalScripts(
   input: PsbtInput,
   script: Buffer,
   isSegwit: boolean,
-  _isTapscript: boolean,
   isP2SH: boolean,
   isP2WSH: boolean,
 ): {

test/psbt.utils.ts

@@ -17,9 +17,9 @@ const buildTapscriptFinalizer = (
     input: PsbtInput,
     script: Buffer,
     _isSegwit: boolean,
-    _isTapscript: boolean,
     _isP2SH: boolean,
     _isP2WSH: boolean,
+    _isTapscript: boolean,
     eccLib?: TinySecp256k1Interface,
   ): {
     finalScriptSig: Buffer | undefined;

ts_src/psbt.ts

@@ -372,9 +372,9 @@ export class Psbt {
       input,
       script,
       isSegwit,
-      isTapscript,
       isP2SH,
       isP2WSH,
+      isTapscript,
       this.__CACHE.__EC_LIB,
     );
 
@@ -1236,9 +1236,9 @@ function getFinalScripts(
   input: PsbtInput,
   script: Buffer,
   isSegwit: boolean,
-  isTapscript: boolean,
   isP2SH: boolean,
   isP2WSH: boolean,
+  isTapscript: boolean = false,
   eccLib?: TinySecp256k1Interface,
 ): {
   finalScriptSig: Buffer | undefined;