Skip to content

Commit 7930209

Browse files
authored
reactions: Increase prominence of own reactions.
To address feedback that own emoji reactions were not sufficiently distinct, we increase the prominence of one's own emoji reactions by: - Setting a pixel-and-a-half border around own reactions. - Reducing the alpha on the inner drop shadow of other reactions. - Increasing the contrast on own reactions borders (and decreasing them, in dark mode, on other reactions). - Space around the emoji is maintained as in the current design in the own reactions. Other reactions benefit from an additional half pixel of padding, top and bottom, which is necessary to keep the pills (and the hover reaction button) the same height as each other--regardless of whether there's an own reaction among them or not. Padding is reduced in line with the increased border on own reactions.
1 parent 5d604a4 commit 7930209

File tree

2 files changed

+17
-6
lines changed

2 files changed

+17
-6
lines changed

web/styles/app_variables.css

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -282,12 +282,12 @@
282282
--color-tab-picker-icon: hsl(200deg 100% 40%);
283283

284284
/* Reaction container colors */
285-
--color-message-reaction-border: hsl(0deg 0% 0% / 12%);
286-
--color-message-reaction-border-reacted: hsl(0deg 0% 0% / 40%);
285+
--color-message-reaction-border: hsl(0deg 0% 0% / 10%);
286+
--color-message-reaction-border-reacted: hsl(0deg 0% 0% / 45%);
287287
--color-message-reaction-background: hsl(0deg 0% 100%);
288288
--color-message-reaction-background-reacted: hsl(0deg 0% 100%);
289289
--color-message-reaction-background-hover: hsl(210deg 30% 96%);
290-
--color-message-reaction-shadow-inner: hsl(210deg 50% 50% / 15%);
290+
--color-message-reaction-shadow-inner: hsl(210deg 50% 50% / 8%);
291291
--color-message-reaction-text: hsl(210deg 20% 25% / 100%);
292292
--color-message-reaction-text-reacted: hsl(210deg 20% 20% / 100%);
293293
--color-message-reaction-button-text: hsl(210deg 20% 20% / 60%);
@@ -583,7 +583,7 @@
583583

584584
/* Reaction container colors */
585585
--color-message-reaction-border: hsl(0deg 0% 100% / 15%);
586-
--color-message-reaction-border-reacted: hsl(0deg 0% 100% / 50%);
586+
--color-message-reaction-border-reacted: hsl(0deg 0% 100% / 70%);
587587
--color-message-reaction-background: hsl(0deg 0% 0% / 30%);
588588
--color-message-reaction-background-reacted: hsl(0deg 0% 0% / 80%);
589589
--color-message-reaction-background-hover: hsl(0deg 0% 100% / 10%);

web/styles/reactions.css

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,9 @@
44

55
.message_reaction {
66
display: flex;
7-
padding: 1px 4px 1px 3px;
7+
/* Set a pixel and half padding to maintain
8+
pill height adjacent own reactions. */
9+
padding: 1.5px 4px 1.5px 3px;
810
box-sizing: border-box;
911
min-width: 44px;
1012
cursor: pointer;
@@ -22,6 +24,13 @@
2224
color: var(--color-message-reaction-text-reacted);
2325
background-color: var(--color-message-reaction-background-reacted);
2426
border-color: var(--color-message-reaction-border-reacted);
27+
/* Make this border thicker by half a pixel,
28+
to make own reactions more prominent. */
29+
border-width: 1.5px;
30+
/* Reduce the padding top and bottom by half
31+
a pixel accordingly, to maintain the same
32+
pill height. */
33+
padding: 1px 4px 1px 3px;
2534
font-weight: var(--font-weight-message-reaction);
2635
box-shadow: none;
2736
}
@@ -37,7 +46,9 @@
3746
+ .reaction_button {
3847
visibility: hidden;
3948
pointer-events: none;
40-
padding: 4px 6px;
49+
/* Set top/bottom padding to accommodate borders
50+
and padding around reaction pills. */
51+
padding: 4.5px 6px;
4152
height: 13px;
4253
border-radius: 21px;
4354
color: var(--color-message-reaction-button-text);

0 commit comments

Comments
 (0)