account [nfc]: Specialize getAccountStatuses as a view-model

This selector has only this one call site; it doesn't seem that
we actually need it more generally.  Move it so that it doesn't
accidentally acquire additional call sites unnecessarily, so that
we're free to revise it as needed to include other data this part
of the UI needs.

Author: gnprice

src/account/AccountItem.js

@@ -10,7 +10,7 @@ import ZulipTextIntl from '../common/ZulipTextIntl';
 import { IconDone, IconTrash } from '../common/Icons';
 import { useGlobalSelector } from '../react-redux';
 import { getIsActiveAccount } from './accountsSelectors';
-import type { AccountStatus } from './accountsSelectors';
+import type { AccountStatus } from './AccountPickScreen';
 
 const styles = createStyleSheet({
   wrapper: {

src/account/AccountList.js

@@ -5,7 +5,7 @@ import { View, FlatList } from 'react-native';
 
 import ViewPlaceholder from '../common/ViewPlaceholder';
 import AccountItem from './AccountItem';
-import type { AccountStatus } from './accountsSelectors';
+import type { AccountStatus } from './AccountPickScreen';
 
 type Props = $ReadOnly<{|
   accountStatuses: $ReadOnlyArray<AccountStatus>,

src/account/AccountPickScreen.js

@@ -4,12 +4,13 @@ import React, { useContext, useCallback } from 'react';
 import type { Node } from 'react';
 import invariant from 'invariant';
 
+import { createSelector } from 'reselect';
 import { fetchServerSettings } from '../message/fetchActions';
 import { TranslationContext } from '../boot/TranslationProvider';
 import type { RouteProp } from '../react-navigation';
 import type { AppNavigationProp } from '../nav/AppNavigator';
 import { useGlobalSelector, useGlobalDispatch } from '../react-redux';
-import { getAccountStatuses, getAccountsByIdentity, getGlobalSettings } from '../selectors';
+import { getAccountsByIdentity, getGlobalSettings } from '../selectors';
 import Centerer from '../common/Centerer';
 import ZulipButton from '../common/ZulipButton';
 import Logo from '../common/Logo';
@@ -19,6 +20,23 @@ import AccountList from './AccountList';
 import { accountSwitch, removeAccount } from '../actions';
 import { showConfirmationDialog, showErrorAlert } from '../utils/info';
 import { tryStopNotifications } from '../notification/notifTokens';
+import type { Identity } from '../types';
+import type { GlobalSelector } from '../reduxTypes';
+import { getAccounts } from '../directSelectors';
+
+/** The data needed for each item in the list-of-accounts UI. */
+export type AccountStatus = {| ...Identity, isLoggedIn: boolean |};
+
+/**
+ * The data needed for the list of accounts in this UI.
+ *
+ * This serves as a view-model for the use of this component.
+ */
+const getAccountStatuses: GlobalSelector<$ReadOnlyArray<AccountStatus>> = createSelector(
+  getAccounts,
+  accounts =>
+    accounts.map(({ realm, email, apiKey }) => ({ realm, email, isLoggedIn: apiKey !== '' })),
+);
 
 type Props = $ReadOnly<{|
   navigation: AppNavigationProp<'account-pick'>,

src/account/accountsSelectors.js

@@ -16,21 +16,6 @@ import { getAccounts } from '../directSelectors';
 import { identityOfAccount, keyOfIdentity, identityOfAuth, authOfAccount } from './accountMisc';
 import { ZulipVersion } from '../utils/zulipVersion';
 
-/** See `getAccountStatuses`. */
-export type AccountStatus = {| ...Identity, isLoggedIn: boolean |};
-
-/**
- * The list of known accounts, with a boolean for logged-in vs. not.
- *
- * This should be used in preference to `getAccounts` where we don't
- * actually need the API keys, but just need to know whether we have them.
- */
-export const getAccountStatuses: GlobalSelector<$ReadOnlyArray<AccountStatus>> = createSelector(
-  getAccounts,
-  accounts =>
-    accounts.map(({ realm, email, apiKey }) => ({ realm, email, isLoggedIn: apiKey !== '' })),
-);
-
 /** The list of known accounts, reduced to `Identity`. */
 export const getIdentities: GlobalSelector<$ReadOnlyArray<Identity>> = createSelector(
   getAccounts,