test [nfc]: Mark unawaited future in tests

These are function calls that need to happen asynchronously until we
elapse the time with FakeAsync or WidgetTester.

Signed-off-by: Zixuan James Li <[email protected]>

Author: PIG208

test/api/fake_api_test.dart

@@ -1,3 +1,5 @@
+import 'dart:async';
+
 import 'package:checks/checks.dart';
 import 'package:test/scaffolding.dart';
 import 'package:zulip/api/exception.dart';
@@ -29,8 +31,8 @@ void main() {
       json: {'a': 3});
 
     Map<String, dynamic>? result;
-    connection.get('aRoute', (json) => json, '/', null)
-      .then((r) { result = r; });
+    unawaited(connection.get('aRoute', (json) => json, '/', null)
+      .then((r) { result = r; }));
 
     async.elapse(const Duration(seconds: 1));
     check(result).isNull();
@@ -45,8 +47,8 @@ void main() {
       exception: Exception("oops"));
 
     Object? error;
-    connection.get('aRoute', (json) => null, '/', null)
-      .catchError((Object e) { error = e; });
+    unawaited(connection.get('aRoute', (json) => null, '/', null)
+      .catchError((Object e) { error = e; }));
 
     async.elapse(const Duration(seconds: 1));
     check(error).isNull();

test/model/store_test.dart

@@ -295,7 +295,7 @@ void main() {
       connection.prepare(exception: Exception('failed'));
       final future = UpdateMachine.load(globalStore, eg.selfAccount.id);
       bool complete = false;
-      future.whenComplete(() => complete = true);
+      unawaited(future.whenComplete(() => complete = true));
       async.flushMicrotasks();
       checkLastRequest();
       check(complete).isFalse();
@@ -363,7 +363,7 @@ void main() {
       connection.prepare(exception: Exception('failed'));
       final future = updateMachine.fetchEmojiData(emojiDataUrl);
       bool complete = false;
-      future.whenComplete(() => complete = true);
+      unawaited(future.whenComplete(() => complete = true));
       async.flushMicrotasks();
       checkLastRequest();
       check(complete).isFalse();

test/widgets/actions_test.dart

@@ -1,3 +1,4 @@
+import 'dart:async';
 import 'dart:convert';
 
 import 'package:checks/checks.dart';
@@ -52,7 +53,7 @@ void main() {
         processedCount: 11, updatedCount: 3,
         firstProcessedId: null, lastProcessedId: null,
         foundOldest: true, foundNewest: true).toJson());
-      markNarrowAsRead(context, narrow);
+      unawaited(markNarrowAsRead(context, narrow));
       await tester.pump(Duration.zero);
       final apiNarrow = narrow.apiEncode()..add(ApiNarrowIs(IsOperand.unread));
       check(connection.lastRequest).isA<http.Request>()
@@ -76,7 +77,7 @@ void main() {
         processedCount: 11, updatedCount: 3,
         firstProcessedId: null, lastProcessedId: null,
         foundOldest: true, foundNewest: true).toJson());
-      markNarrowAsRead(context, narrow);
+      unawaited(markNarrowAsRead(context, narrow));
       await tester.pump(Duration.zero);
       check(connection.lastRequest).isA<http.Request>()
         ..method.equals('POST')
@@ -101,7 +102,7 @@ void main() {
         processedCount: 11, updatedCount: 3,
         firstProcessedId: null, lastProcessedId: null,
         foundOldest: true, foundNewest: true).toJson());
-      markNarrowAsRead(context, narrow);
+      unawaited(markNarrowAsRead(context, narrow));
       await tester.pump(Duration.zero);
       await tester.pumpAndSettle();
       check(store.unreads.oldUnreadsMissing).isFalse();
@@ -115,7 +116,7 @@ void main() {
 
       connection.zulipFeatureLevel = 154;
       connection.prepare(json: {});
-      markNarrowAsRead(context, narrow);
+      unawaited(markNarrowAsRead(context, narrow));
       await tester.pump(Duration.zero);
       check(connection.lastRequest).isA<http.Request>()
         ..method.equals('POST')
@@ -133,7 +134,7 @@ void main() {
       await prepare(tester);
       connection.zulipFeatureLevel = 154;
       connection.prepare(json: {});
-      markNarrowAsRead(context, narrow);
+      unawaited(markNarrowAsRead(context, narrow));
       await tester.pump(Duration.zero);
       check(connection.lastRequest).isA<http.Request>()
         ..method.equals('POST')
@@ -148,7 +149,7 @@ void main() {
       await prepare(tester);
       connection.zulipFeatureLevel = 154;
       connection.prepare(json: {});
-      markNarrowAsRead(context, narrow);
+      unawaited(markNarrowAsRead(context, narrow));
       await tester.pump(Duration.zero);
       check(connection.lastRequest).isA<http.Request>()
         ..method.equals('POST')
@@ -170,7 +171,7 @@ void main() {
       connection.zulipFeatureLevel = 154;
       connection.prepare(json:
         UpdateMessageFlagsResult(messages: [message.id]).toJson());
-      markNarrowAsRead(context, narrow);
+      unawaited(markNarrowAsRead(context, narrow));
       await tester.pump(Duration.zero);
       check(connection.lastRequest).isA<http.Request>()
         ..method.equals('POST')
@@ -190,7 +191,7 @@ void main() {
       connection.zulipFeatureLevel = 154;
       connection.prepare(json:
         UpdateMessageFlagsResult(messages: [message.id]).toJson());
-      markNarrowAsRead(context, narrow);
+      unawaited(markNarrowAsRead(context, narrow));
       await tester.pump(Duration.zero);
       check(connection.lastRequest).isA<http.Request>()
         ..method.equals('POST')

test/widgets/lightbox_test.dart

@@ -213,14 +213,14 @@ void main() {
       await tester.pumpWidget(const ZulipApp());
       await tester.pump();
       final navigator = await ZulipApp.navigator;
-      navigator.push(getImageLightboxRoute(
+      unawaited(navigator.push(getImageLightboxRoute(
         accountId: eg.selfAccount.id,
         message: message ?? eg.streamMessage(),
         src: src,
         thumbnailUrl: thumbnailUrl,
         originalHeight: null,
         originalWidth: null,
-      ));
+      )));
       await tester.pump(); // per-account store
       await tester.pump(const Duration(milliseconds: 301)); // nav transition
     }

test/widgets/login_test.dart

@@ -1,3 +1,5 @@
+import 'dart:async';
+
 import 'package:checks/checks.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter/services.dart';
@@ -90,7 +92,7 @@ void main() {
       await tester.pumpWidget(ZulipApp(navigatorObservers: [testNavObserver]));
       await tester.pump();
       final navigator = await ZulipApp.navigator;
-      navigator.push(LoginPage.buildRoute(serverSettings: serverSettings));
+      unawaited(navigator.push(LoginPage.buildRoute(serverSettings: serverSettings)));
       await tester.pumpAndSettle();
       takeStartingRoutes();
       check(pushedRoutes).isEmpty();