@@ -291,6 +291,7 @@ class _MessageListPageState extends State<MessageListPage> implements MessageLis
291
291
builder: (BuildContext context) => Column (
292
292
// Children are expected to take the full horizontal space
293
293
// and handle the horizontal device insets.
294
+ // The bottom inset should be handled by the last child only.
294
295
children: [
295
296
MediaQuery .removePadding (
296
297
// Scaffold knows about the app bar, and so has run this
@@ -448,7 +449,9 @@ const kFetchMessagesBufferPixels = (kMessageListFetchBatchSize / 2) * _kShortMes
448
449
///
449
450
/// Takes the full screen width,
450
451
/// keeping the message list and scroll-to-bottom button
451
- /// out of the horizontal insets with transparent [SafeArea] padding.
452
+ /// out of the horizontal and bottom insets with transparent [SafeArea] padding.
453
+ /// When there is no [ComposeBox] , adds a [SliverSafeArea] , to ensure
454
+ /// content can be scrolled out of the bottom inset.
452
455
class MessageList extends StatefulWidget {
453
456
const MessageList ({super .key, required this .narrow, required this .onNarrowChanged});
454
457
@@ -562,7 +565,8 @@ class _MessageListState extends State<MessageList> with PerAccountStoreAwareStat
562
565
bottom: 0 ,
563
566
right: 0 ,
564
567
// TODO(#311) SafeArea shouldn't be needed if we have a
565
- // bottom nav. That will pad the bottom inset.
568
+ // bottom nav; that will pad the bottom inset. Remove it,
569
+ // and the mention of bottom padding in MessageList dartdoc.
566
570
child: SafeArea (
567
571
child: ScrollToBottomButton (
568
572
scrollController: scrollController,
@@ -613,8 +617,8 @@ class _MessageListState extends State<MessageList> with PerAccountStoreAwareStat
613
617
}));
614
618
615
619
if (! ComposeBox .hasComposeBox (widget.narrow)) {
616
- // TODO(#311) If we have a bottom nav, it will pad the bottom
617
- // inset, and this shouldn't be necessary
620
+ // TODO(#311) If we have a bottom nav, it will pad the bottom inset,
621
+ // and this can be removed; also remove mention in MessageList dartdoc
618
622
sliver = SliverSafeArea (sliver: sliver);
619
623
}
620
624
0 commit comments