Skip to content

Commit cd6c022

Browse files
committed
msglist [nfc]: Add TODO(design) with unanswered question for date separator
In #469 implementing date separators, Greg highlighted that the date separator's deviation from web wasn't settled yet: #469 (comment) #469 (comment)
1 parent cacab65 commit cd6c022

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

lib/widgets/message_list.dart

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -519,6 +519,13 @@ class DateSeparator extends StatelessWidget {
519519

520520
final Message message;
521521

522+
// TODO(design) Do we want to match web more closely?
523+
// - width of 1 logical pixel instead of 1 physical pixel
524+
// - opacity 0.15
525+
static const _line = BorderSide(
526+
width: 0,
527+
color: Colors.black);
528+
522529
@override
523530
Widget build(BuildContext context) {
524531
// This makes the small-caps text vertically centered,
@@ -534,9 +541,7 @@ class DateSeparator extends StatelessWidget {
534541
child: DecoratedBox(
535542
decoration: BoxDecoration(
536543
border: Border(
537-
bottom: BorderSide(
538-
width: 0,
539-
color: Colors.black)))))),
544+
bottom: _line))))),
540545
Padding(padding: const EdgeInsets.fromLTRB(2, 0, 2, textBottomPadding),
541546
child: DateText(
542547
fontSize: 16,
@@ -546,9 +551,7 @@ class DateSeparator extends StatelessWidget {
546551
child: DecoratedBox(
547552
decoration: BoxDecoration(
548553
border: Border(
549-
bottom: BorderSide(
550-
width: 0,
551-
color: Colors.black)))))
554+
bottom: _line)))),
552555
])),
553556
);
554557
}

0 commit comments

Comments
 (0)