Skip to content

Commit c47514e

Browse files
committed
action_sheet test [nfc]: Add groups for 'in {topic,DM} narrow' tests
Each of these tests will get a new related test, coming up.
1 parent 01f59be commit c47514e

File tree

1 file changed

+34
-30
lines changed

1 file changed

+34
-30
lines changed

test/widgets/action_sheet_test.dart

Lines changed: 34 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -296,39 +296,43 @@ void main() {
296296
valueBefore: valueBefore, message: message, rawContent: 'Hello world');
297297
});
298298

299-
testWidgets('in topic narrow', (tester) async {
300-
final message = eg.streamMessage();
301-
await setupToMessageActionSheet(tester, message: message, narrow: TopicNarrow.ofMessage(message));
302-
303-
final composeBoxController = findComposeBoxController(tester)!;
304-
final contentController = composeBoxController.contentController;
299+
group('in topic narrow', () {
300+
testWidgets('smoke', (tester) async {
301+
final message = eg.streamMessage();
302+
await setupToMessageActionSheet(tester, message: message, narrow: TopicNarrow.ofMessage(message));
305303

306-
final valueBefore = contentController.value;
307-
prepareRawContentResponseSuccess(message: message, rawContent: 'Hello world');
308-
await tapQuoteAndReplyButton(tester);
309-
checkLoadingState(store, contentController, valueBefore: valueBefore, message: message);
310-
await tester.pump(Duration.zero); // message is fetched; compose box updates
311-
check(composeBoxController.contentFocusNode.hasFocus).isTrue();
312-
checkSuccessState(store, contentController,
313-
valueBefore: valueBefore, message: message, rawContent: 'Hello world');
304+
final composeBoxController = findComposeBoxController(tester)!;
305+
final contentController = composeBoxController.contentController;
306+
307+
final valueBefore = contentController.value;
308+
prepareRawContentResponseSuccess(message: message, rawContent: 'Hello world');
309+
await tapQuoteAndReplyButton(tester);
310+
checkLoadingState(store, contentController, valueBefore: valueBefore, message: message);
311+
await tester.pump(Duration.zero); // message is fetched; compose box updates
312+
check(composeBoxController.contentFocusNode.hasFocus).isTrue();
313+
checkSuccessState(store, contentController,
314+
valueBefore: valueBefore, message: message, rawContent: 'Hello world');
315+
});
314316
});
315317

316-
testWidgets('in DM narrow', (tester) async {
317-
final message = eg.dmMessage(from: eg.selfUser, to: [eg.otherUser]);
318-
await setupToMessageActionSheet(tester,
319-
message: message, narrow: DmNarrow.ofMessage(message, selfUserId: eg.selfUser.userId));
320-
321-
final composeBoxController = findComposeBoxController(tester)!;
322-
final contentController = composeBoxController.contentController;
323-
324-
final valueBefore = contentController.value;
325-
prepareRawContentResponseSuccess(message: message, rawContent: 'Hello world');
326-
await tapQuoteAndReplyButton(tester);
327-
checkLoadingState(store, contentController, valueBefore: valueBefore, message: message);
328-
await tester.pump(Duration.zero); // message is fetched; compose box updates
329-
check(composeBoxController.contentFocusNode.hasFocus).isTrue();
330-
checkSuccessState(store, contentController,
331-
valueBefore: valueBefore, message: message, rawContent: 'Hello world');
318+
group('in DM narrow', () {
319+
testWidgets('smoke', (tester) async {
320+
final message = eg.dmMessage(from: eg.selfUser, to: [eg.otherUser]);
321+
await setupToMessageActionSheet(tester,
322+
message: message, narrow: DmNarrow.ofMessage(message, selfUserId: eg.selfUser.userId));
323+
324+
final composeBoxController = findComposeBoxController(tester)!;
325+
final contentController = composeBoxController.contentController;
326+
327+
final valueBefore = contentController.value;
328+
prepareRawContentResponseSuccess(message: message, rawContent: 'Hello world');
329+
await tapQuoteAndReplyButton(tester);
330+
checkLoadingState(store, contentController, valueBefore: valueBefore, message: message);
331+
await tester.pump(Duration.zero); // message is fetched; compose box updates
332+
check(composeBoxController.contentFocusNode.hasFocus).isTrue();
333+
checkSuccessState(store, contentController,
334+
valueBefore: valueBefore, message: message, rawContent: 'Hello world');
335+
});
332336
});
333337

334338
testWidgets('request has an error', (tester) async {

0 commit comments

Comments
 (0)