Skip to content

Commit b69f0bf

Browse files
committed
msglist test [nfc]: Move notifyListeners tests to match implementation
Signed-off-by: Zixuan James Li <[email protected]>
1 parent 99a62b7 commit b69f0bf

File tree

1 file changed

+62
-62
lines changed

1 file changed

+62
-62
lines changed

test/model/message_list_test.dart

Lines changed: 62 additions & 62 deletions
Original file line numberDiff line numberDiff line change
@@ -508,68 +508,6 @@ void main() {
508508
});
509509
});
510510

511-
group('notifyListenersIfMessagePresent', () {
512-
test('message present', () async {
513-
await prepare(narrow: const CombinedFeedNarrow());
514-
await prepareMessages(foundOldest: false,
515-
messages: List.generate(100, (i) => eg.streamMessage(id: 100 + i)));
516-
model.notifyListenersIfMessagePresent(150);
517-
checkNotifiedOnce();
518-
});
519-
520-
test('message absent', () async {
521-
await prepare(narrow: const CombinedFeedNarrow());
522-
await prepareMessages(foundOldest: false,
523-
messages: List.generate(100, (i) => eg.streamMessage(id: 100 + i))
524-
.where((m) => m.id != 150).toList());
525-
model.notifyListenersIfMessagePresent(150);
526-
checkNotNotified();
527-
});
528-
529-
test('message absent (older than window)', () async {
530-
await prepare(narrow: const CombinedFeedNarrow());
531-
await prepareMessages(foundOldest: false,
532-
messages: List.generate(100, (i) => eg.streamMessage(id: 100 + i)));
533-
model.notifyListenersIfMessagePresent(50);
534-
checkNotNotified();
535-
});
536-
537-
test('message absent (newer than window)', () async {
538-
await prepare(narrow: const CombinedFeedNarrow());
539-
await prepareMessages(foundOldest: false,
540-
messages: List.generate(100, (i) => eg.streamMessage(id: 100 + i)));
541-
model.notifyListenersIfMessagePresent(250);
542-
checkNotNotified();
543-
});
544-
});
545-
546-
group('notifyListenersIfAnyMessagePresent', () {
547-
final messages = List.generate(100, (i) => eg.streamMessage(id: 100 + i));
548-
549-
test('all messages present', () async {
550-
await prepare(narrow: const CombinedFeedNarrow());
551-
await prepareMessages(foundOldest: false, messages: messages);
552-
model.notifyListenersIfAnyMessagePresent([150, 151, 152]);
553-
checkNotifiedOnce();
554-
});
555-
556-
test('some messages present', () async {
557-
await prepare(narrow: const CombinedFeedNarrow());
558-
await prepareMessages(foundOldest: false,
559-
messages: messages.where((m) => m.id != 151).toList());
560-
model.notifyListenersIfAnyMessagePresent([150, 151, 152]);
561-
checkNotifiedOnce();
562-
});
563-
564-
test('no messages present', () async {
565-
await prepare(narrow: const CombinedFeedNarrow());
566-
await prepareMessages(foundOldest: false, messages:
567-
messages.where((m) => ![150, 151, 152].contains(m.id)).toList());
568-
model.notifyListenersIfAnyMessagePresent([150, 151, 152]);
569-
checkNotNotified();
570-
});
571-
});
572-
573511
group('handleMessageEvent', () {
574512
test('in narrow', () async {
575513
final stream = eg.stream();
@@ -1140,6 +1078,68 @@ void main() {
11401078
});
11411079
});
11421080

1081+
group('notifyListenersIfMessagePresent', () {
1082+
test('message present', () async {
1083+
await prepare(narrow: const CombinedFeedNarrow());
1084+
await prepareMessages(foundOldest: false,
1085+
messages: List.generate(100, (i) => eg.streamMessage(id: 100 + i)));
1086+
model.notifyListenersIfMessagePresent(150);
1087+
checkNotifiedOnce();
1088+
});
1089+
1090+
test('message absent', () async {
1091+
await prepare(narrow: const CombinedFeedNarrow());
1092+
await prepareMessages(foundOldest: false,
1093+
messages: List.generate(100, (i) => eg.streamMessage(id: 100 + i))
1094+
.where((m) => m.id != 150).toList());
1095+
model.notifyListenersIfMessagePresent(150);
1096+
checkNotNotified();
1097+
});
1098+
1099+
test('message absent (older than window)', () async {
1100+
await prepare(narrow: const CombinedFeedNarrow());
1101+
await prepareMessages(foundOldest: false,
1102+
messages: List.generate(100, (i) => eg.streamMessage(id: 100 + i)));
1103+
model.notifyListenersIfMessagePresent(50);
1104+
checkNotNotified();
1105+
});
1106+
1107+
test('message absent (newer than window)', () async {
1108+
await prepare(narrow: const CombinedFeedNarrow());
1109+
await prepareMessages(foundOldest: false,
1110+
messages: List.generate(100, (i) => eg.streamMessage(id: 100 + i)));
1111+
model.notifyListenersIfMessagePresent(250);
1112+
checkNotNotified();
1113+
});
1114+
});
1115+
1116+
group('notifyListenersIfAnyMessagePresent', () {
1117+
final messages = List.generate(100, (i) => eg.streamMessage(id: 100 + i));
1118+
1119+
test('all messages present', () async {
1120+
await prepare(narrow: const CombinedFeedNarrow());
1121+
await prepareMessages(foundOldest: false, messages: messages);
1122+
model.notifyListenersIfAnyMessagePresent([150, 151, 152]);
1123+
checkNotifiedOnce();
1124+
});
1125+
1126+
test('some messages present', () async {
1127+
await prepare(narrow: const CombinedFeedNarrow());
1128+
await prepareMessages(foundOldest: false,
1129+
messages: messages.where((m) => m.id != 151).toList());
1130+
model.notifyListenersIfAnyMessagePresent([150, 151, 152]);
1131+
checkNotifiedOnce();
1132+
});
1133+
1134+
test('no messages present', () async {
1135+
await prepare(narrow: const CombinedFeedNarrow());
1136+
await prepareMessages(foundOldest: false, messages:
1137+
messages.where((m) => ![150, 151, 152].contains(m.id)).toList());
1138+
model.notifyListenersIfAnyMessagePresent([150, 151, 152]);
1139+
checkNotNotified();
1140+
});
1141+
});
1142+
11431143
group('regression tests for #455', () {
11441144
test('reaction events handled once, even when message is in two message lists', () async {
11451145
final stream = eg.stream();

0 commit comments

Comments
 (0)