Skip to content

Commit afaf8f3

Browse files
committed
msglist test: Move two stream-recipient-header tests into their group
These belong in this StreamMessageRecipientHeader group.
1 parent 61be55b commit afaf8f3

File tree

1 file changed

+32
-32
lines changed

1 file changed

+32
-32
lines changed

test/widgets/message_list_test.dart

Lines changed: 32 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -332,40 +332,40 @@ void main() {
332332
matching: find.byIcon(ZulipIcons.lock),
333333
).evaluate()).length.equals(1);
334334
});
335-
});
336335

337-
testWidgets('show stream name from message when stream unknown', (tester) async {
338-
// This can perfectly well happen, because message fetches can race
339-
// with events.
340-
// … Though not actually with AllMessagesNarrow, because that shows
341-
// stream messages only in subscribed streams, hence only known streams.
342-
// See skip comment below.
343-
final stream = eg.stream(name: 'stream name');
344-
await setupMessageListPage(tester,
345-
narrow: const AllMessagesNarrow(),
346-
subscriptions: [],
347-
messages: [
348-
eg.streamMessage(stream: stream),
349-
]);
350-
await tester.pump();
351-
tester.widget(find.text('stream name'));
352-
}, skip: true); // TODO(#252) could repro this with search narrows, once we have those
353-
354-
testWidgets('show stream name from stream data when known', (tester) async {
355-
final streamBefore = eg.stream(name: 'old stream name');
356-
// TODO(#182) this test would be more realistic using a StreamUpdateEvent
357-
final streamAfter = ZulipStream.fromJson({
358-
...(deepToJson(streamBefore) as Map<String, dynamic>),
359-
'name': 'new stream name',
336+
testWidgets('show stream name from message when stream unknown', (tester) async {
337+
// This can perfectly well happen, because message fetches can race
338+
// with events.
339+
// … Though not actually with AllMessagesNarrow, because that shows
340+
// stream messages only in subscribed streams, hence only known streams.
341+
// See skip comment below.
342+
final stream = eg.stream(name: 'stream name');
343+
await setupMessageListPage(tester,
344+
narrow: const AllMessagesNarrow(),
345+
subscriptions: [],
346+
messages: [
347+
eg.streamMessage(stream: stream),
348+
]);
349+
await tester.pump();
350+
tester.widget(find.text('stream name'));
351+
}, skip: true); // TODO(#252) could repro this with search narrows, once we have those
352+
353+
testWidgets('show stream name from stream data when known', (tester) async {
354+
final streamBefore = eg.stream(name: 'old stream name');
355+
// TODO(#182) this test would be more realistic using a StreamUpdateEvent
356+
final streamAfter = ZulipStream.fromJson({
357+
...(deepToJson(streamBefore) as Map<String, dynamic>),
358+
'name': 'new stream name',
359+
});
360+
await setupMessageListPage(tester,
361+
narrow: const AllMessagesNarrow(),
362+
subscriptions: [eg.subscription(streamAfter)],
363+
messages: [
364+
eg.streamMessage(stream: streamBefore),
365+
]);
366+
await tester.pump();
367+
tester.widget(find.text('new stream name'));
360368
});
361-
await setupMessageListPage(tester,
362-
narrow: const AllMessagesNarrow(),
363-
subscriptions: [eg.subscription(streamAfter)],
364-
messages: [
365-
eg.streamMessage(stream: streamBefore),
366-
]);
367-
await tester.pump();
368-
tester.widget(find.text('new stream name'));
369369
});
370370

371371
testWidgets('show names on DMs', (tester) async {

0 commit comments

Comments
 (0)