Skip to content

Commit a1e1858

Browse files
notif [nfc]: Use localization for self user display name
1 parent 002c6aa commit a1e1858

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

assets/l10n/app_en.arb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -479,5 +479,9 @@
479479
"senderFullName": {"type": "String", "example": "Alice"},
480480
"numOthers": {"type": "int", "example": "4"}
481481
}
482+
},
483+
"notifSelfUser": "You",
484+
"@notifSelfUser": {
485+
"description": "Display name supposed to be temporarily displayed after replying to a message in Android notification"
482486
}
483487
}

lib/notifications/display.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ class NotificationDisplayManager {
108108
messagingStyle = MessagingStyle(
109109
user: Person(
110110
key: _personKey(data.realmUri, data.userId),
111-
name: 'You'), // TODO(i18n)
111+
name: zulipLocalizations.notifSelfUser),
112112
messages: [],
113113
isGroupConversation: switch (data.recipient) {
114114
FcmMessageStreamRecipient() => true,

test/notifications/display_test.dart

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import 'package:flutter_test/flutter_test.dart';
1010
import 'package:zulip/api/model/model.dart';
1111
import 'package:zulip/api/notifications.dart';
1212
import 'package:zulip/host/android_notifications.dart';
13+
import 'package:zulip/model/localizations.dart';
1314
import 'package:zulip/model/narrow.dart';
1415
import 'package:zulip/model/store.dart';
1516
import 'package:zulip/notifications/display.dart';
@@ -75,6 +76,7 @@ MessageFcmMessage messageFcmMessage(
7576

7677
void main() {
7778
TestZulipBinding.ensureInitialized();
79+
final zulipLocalizations = GlobalLocalizations.zulipLocalizations;
7880

7981
Future<void> init() async {
8082
addTearDown(testBinding.reset);
@@ -149,7 +151,7 @@ void main() {
149151
..user.which((it) => it.isNotNull()
150152
..iconBitmap.isNull()
151153
..key.equals(expectedSelfUserKey)
152-
..name.equals('You')) // TODO(i18n)
154+
..name.equals(zulipLocalizations.notifSelfUser))
153155
..isGroupConversation.equals(expectedGroup)
154156
..conversationTitle.equals(expectedTitle)
155157
..messages.which((it) => it

0 commit comments

Comments
 (0)