Skip to content

Commit 6f2402b

Browse files
PIG208github-actions[bot]
authored andcommitted
i18n: Sweep for non-localized '(unknown channel)' strings
Renamed the "composeBoxUnknownChannelName" string to generalize it. Signed-off-by: Zixuan James Li <[email protected]>
1 parent 0ae137a commit 6f2402b

12 files changed

+18
-15
lines changed

assets/l10n/app_en.arb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -325,8 +325,8 @@
325325
"@composeBoxSendTooltip": {
326326
"description": "Tooltip for send button in compose box."
327327
},
328-
"composeBoxUnknownChannelName": "(unknown channel)",
329-
"@composeBoxUnknownChannelName": {
328+
"unknownChannelName": "(unknown channel)",
329+
"@unknownChannelName": {
330330
"description": "Replacement name for channel when it cannot be found in the store."
331331
},
332332
"composeBoxTopicHintText": "Topic",

lib/generated/l10n/zulip_localizations.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -541,7 +541,7 @@ abstract class ZulipLocalizations {
541541
///
542542
/// In en, this message translates to:
543543
/// **'(unknown channel)'**
544-
String get composeBoxUnknownChannelName;
544+
String get unknownChannelName;
545545

546546
/// Hint text for topic input widget in compose box.
547547
///

lib/generated/l10n/zulip_localizations_ar.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
259259
String get composeBoxSendTooltip => 'Send';
260260

261261
@override
262-
String get composeBoxUnknownChannelName => '(unknown channel)';
262+
String get unknownChannelName => '(unknown channel)';
263263

264264
@override
265265
String get composeBoxTopicHintText => 'Topic';

lib/generated/l10n/zulip_localizations_en.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
259259
String get composeBoxSendTooltip => 'Send';
260260

261261
@override
262-
String get composeBoxUnknownChannelName => '(unknown channel)';
262+
String get unknownChannelName => '(unknown channel)';
263263

264264
@override
265265
String get composeBoxTopicHintText => 'Topic';

lib/generated/l10n/zulip_localizations_ja.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ class ZulipLocalizationsJa extends ZulipLocalizations {
259259
String get composeBoxSendTooltip => 'Send';
260260

261261
@override
262-
String get composeBoxUnknownChannelName => '(unknown channel)';
262+
String get unknownChannelName => '(unknown channel)';
263263

264264
@override
265265
String get composeBoxTopicHintText => 'Topic';

lib/generated/l10n/zulip_localizations_nb.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ class ZulipLocalizationsNb extends ZulipLocalizations {
259259
String get composeBoxSendTooltip => 'Send';
260260

261261
@override
262-
String get composeBoxUnknownChannelName => '(unknown channel)';
262+
String get unknownChannelName => '(unknown channel)';
263263

264264
@override
265265
String get composeBoxTopicHintText => 'Topic';

lib/generated/l10n/zulip_localizations_pl.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ class ZulipLocalizationsPl extends ZulipLocalizations {
259259
String get composeBoxSendTooltip => 'Wyślij';
260260

261261
@override
262-
String get composeBoxUnknownChannelName => '(nieznany kanał)';
262+
String get unknownChannelName => '(unknown channel)';
263263

264264
@override
265265
String get composeBoxTopicHintText => 'Wątek';

lib/generated/l10n/zulip_localizations_ru.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ class ZulipLocalizationsRu extends ZulipLocalizations {
259259
String get composeBoxSendTooltip => 'Отправить';
260260

261261
@override
262-
String get composeBoxUnknownChannelName => '(неизвестный канал)';
262+
String get unknownChannelName => '(unknown channel)';
263263

264264
@override
265265
String get composeBoxTopicHintText => 'Тема';

lib/generated/l10n/zulip_localizations_sk.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ class ZulipLocalizationsSk extends ZulipLocalizations {
259259
String get composeBoxSendTooltip => 'Send';
260260

261261
@override
262-
String get composeBoxUnknownChannelName => '(unknown channel)';
262+
String get unknownChannelName => '(unknown channel)';
263263

264264
@override
265265
String get composeBoxTopicHintText => 'Topic';

lib/notifications/display.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ class NotificationDisplayManager {
263263
FcmMessageChannelRecipient(:var streamName?, :var topic) =>
264264
'#$streamName > ${topic.displayName}',
265265
FcmMessageChannelRecipient(:var topic) =>
266-
'#(unknown channel) > ${topic.displayName}', // TODO get stream name from data
266+
'#${zulipLocalizations.unknownChannelName} > ${topic.displayName}', // TODO get stream name from data
267267
FcmMessageDmRecipient(:var allRecipientIds) when allRecipientIds.length > 2 =>
268268
zulipLocalizations.notifGroupDmConversationLabel(
269269
data.senderFullName, allRecipientIds.length - 2), // TODO use others' names, from data

lib/widgets/compose_box.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -574,7 +574,7 @@ class _StreamContentInputState extends State<_StreamContentInput> {
574574
final store = PerAccountStoreWidget.of(context);
575575
final zulipLocalizations = ZulipLocalizations.of(context);
576576
final streamName = store.streams[widget.narrow.streamId]?.name
577-
?? zulipLocalizations.composeBoxUnknownChannelName;
577+
?? zulipLocalizations.unknownChannelName;
578578
return _ContentInput(
579579
narrow: widget.narrow,
580580
destination: TopicNarrow(widget.narrow.streamId, TopicName(_topicTextNormalized)),
@@ -636,7 +636,7 @@ class _FixedDestinationContentInput extends StatelessWidget {
636636
case TopicNarrow(:final streamId, :final topic):
637637
final store = PerAccountStoreWidget.of(context);
638638
final streamName = store.streams[streamId]?.name
639-
?? zulipLocalizations.composeBoxUnknownChannelName;
639+
?? zulipLocalizations.unknownChannelName;
640640
return zulipLocalizations.composeBoxChannelContentHint(
641641
streamName, topic.displayName);
642642

lib/widgets/message_list.dart

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -335,6 +335,7 @@ class MessageListAppBarTitle extends StatelessWidget {
335335
Widget _buildStreamRow(BuildContext context, {
336336
ZulipStream? stream,
337337
}) {
338+
final zulipLocalizations = ZulipLocalizations.of(context);
338339
// A null [Icon.icon] makes a blank space.
339340
final icon = stream != null ? iconDataForStream(stream) : null;
340341
return Row(
@@ -346,7 +347,8 @@ class MessageListAppBarTitle extends StatelessWidget {
346347
children: [
347348
Icon(size: 16, icon),
348349
const SizedBox(width: 4),
349-
Flexible(child: Text(stream?.name ?? '(unknown channel)')),
350+
Flexible(child: Text(
351+
stream?.name ?? zulipLocalizations.unknownChannelName)),
350352
]);
351353
}
352354

@@ -1031,6 +1033,7 @@ class StreamMessageRecipientHeader extends StatelessWidget {
10311033
// https://github.com/zulip/zulip-mobile/issues/5511
10321034
final store = PerAccountStoreWidget.of(context);
10331035
final designVariables = DesignVariables.of(context);
1036+
final zulipLocalizations = ZulipLocalizations.of(context);
10341037

10351038
final topic = message.topic;
10361039

@@ -1055,7 +1058,7 @@ class StreamMessageRecipientHeader extends StatelessWidget {
10551058
final stream = store.streams[message.streamId];
10561059
final streamName = stream?.name
10571060
?? message.displayRecipient
1058-
?? '(unknown channel)'; // TODO(log)
1061+
?? zulipLocalizations.unknownChannelName; // TODO(log)
10591062

10601063
streamWidget = GestureDetector(
10611064
onTap: () => Navigator.push(context,

0 commit comments

Comments
 (0)