Skip to content

Commit 634cd43

Browse files
committed
dialog: translations
1 parent 8b94b29 commit 634cd43

File tree

2 files changed

+18
-4
lines changed

2 files changed

+18
-4
lines changed

assets/l10n/app_en.arb

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,18 @@
7575
"@actionSheetShare": {
7676
"description": "Label for share button on action sheet."
7777
},
78+
"dialogButtonOK": "OK",
79+
"@dialogButtonOK": {
80+
"description": "Button label in generic dialogs to confirm."
81+
},
82+
"dialogButtonCancel": "Cancel",
83+
"@dialogButtonCancel": {
84+
"description": "Button label in generic dialogs to cancel."
85+
},
86+
"dialogButtonContinue": "Continue",
87+
"@dialogButtonContinue": {
88+
"description": "Button label in generic dialogs to continue."
89+
},
7890
"lightboxCopyLinkTooltip": "Copy link",
7991
"@lightboxCopyLinkTooltip": {
8092
"description": "Tooltip in lightbox for the copy link action."

lib/widgets/dialog.dart

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import 'package:flutter/material.dart';
2+
import 'package:flutter_gen/gen_l10n/zulip_localizations.dart';
23

34
Widget _dialogActionText(String text) {
45
return Text(
@@ -14,12 +15,12 @@ Widget _dialogActionText(String text) {
1415
);
1516
}
1617

17-
// TODO(i18n): title, message, and action-button text
1818
Future<void> showErrorDialog({
1919
required BuildContext context,
2020
required String title,
2121
String? message,
2222
}) {
23+
final zulipLocalizations = ZulipLocalizations.of(context);
2324
return showDialog(
2425
context: context,
2526
builder: (BuildContext context) => AlertDialog(
@@ -28,7 +29,7 @@ Future<void> showErrorDialog({
2829
actions: [
2930
TextButton(
3031
onPressed: () => Navigator.pop(context),
31-
child: _dialogActionText('OK')),
32+
child: _dialogActionText(zulipLocalizations.dialogButtonOK)),
3233
]));
3334
}
3435

@@ -39,6 +40,7 @@ void showSuggestedActionDialog({
3940
required String? actionButtonText,
4041
required VoidCallback onActionButtonPress,
4142
}) {
43+
final zulipLocalizations = ZulipLocalizations.of(context);
4244
showDialog(
4345
context: context,
4446
builder: (BuildContext context) => AlertDialog(
@@ -47,9 +49,9 @@ void showSuggestedActionDialog({
4749
actions: [
4850
TextButton(
4951
onPressed: () => Navigator.pop(context),
50-
child: _dialogActionText('Cancel')),
52+
child: _dialogActionText(zulipLocalizations.dialogButtonCancel)),
5153
TextButton(
5254
onPressed: onActionButtonPress,
53-
child: _dialogActionText(actionButtonText ?? 'Continue')),
55+
child: _dialogActionText(actionButtonText ?? zulipLocalizations.dialogButtonContinue)),
5456
]));
5557
}

0 commit comments

Comments
 (0)